<div dir="ltr">Thanks a lot, folks! I'll try that.<div><br></div><div>BTW, I was very suspicious about having separate projects for different things from the beginning. I even shared my opinion one night (afternoon for you). Is it done because of technical requirements (Weld, Furnace) or just because you think that this is a good design approach?</div>
<div><br></div><div>Cheers,</div><div>Ivan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 10, 2013 at 5:08 PM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I've attached a working update to your code:</div><div><br></div>The reason this occurred is because you did not specify addon dependencies in your addon/pom.xml, you only referenced them in your sub-projects.<div>
<br></div><div>Actually we considered allowing this to work from any sub-dependency of the addon, but... im not sure that's a good idea. I like the "do what I expect" concept, but I'm not sure of the consequences of this. Perhaps now is a good time to discuss this since our first user has banged their head against this issue.<br>
<div><br>Additionally, your test case needed to reference the maven addon, because otherwise there will be no implementation of the projects API and the project returned from projectFactory would be null.</div></div></div>
<div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 10, 2013 at 10:05 AM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Part of your problem is this:<div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.WeldBootstrap startContainer</p>
<p>INFO: WELD-000101 Transactional services not available. Injection of @Inject UserTransaction not available. Transactional observers will be invoked synchronously.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.gitignore.GitIgnoreConfig because of underlying class loading error: Type Lorg.jboss.forge.addon.configuration.ConfigurationFactory; not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.AbstractGitCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadClass</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitCheckoutCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.UICommand not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitCloneCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreAddPatternCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadClass</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreCreateCommand$GitIgnoreTemplateCompleter because of underlying class loading error: Type org.jboss.forge.addon.ui.input.UICompleter not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreCreateCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreEditCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreListPatternsCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreListTemplatesCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadClass</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreRemovePatternCommand$GitIgnorePatternCompleter because of underlying class loading error: Type org.jboss.forge.addon.ui.input.UICompleter not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreRemovePatternCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadClass</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreSetupCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.UICommand not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadAnnotatedType</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.GitIgnoreUpdateRepoCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.metadata.UICommandMetadata not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.weld.bootstrap.BeanDeployer loadClass</p>
<p>INFO: WELD-000119 Not generating any bean definitions from org.jboss.forge.addon.git.ui.LsGitIgnoreCommand because of underlying class loading error: Type org.jboss.forge.addon.ui.UICommand not found. If this is unexpected, enable DEBUG logging to see the full error.</p>
<p>Sep 10, 2013 9:56:58 AM org.jboss.forge.furnace.impl.addons.AddonRunnable run</p></blockquote></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Tue, Sep 10, 2013 at 8:57 AM, Ivan St. Ivanov <span dir="ltr"><<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, I have it in a separate branch. As always, I create a branch with the JIRA issue</div><div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 10, 2013 at 3:45 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Do you have this code in a separate branch? I think it's easier for
us to test and provide patches if necessary. <br>
I noticed that you need a package-info.java in the addon project (It
is now fixed in Alpha12).<div><div><br>
<br>
<br>
<div>On 09/10/2013 08:27 AM, Ivan St. Ivanov
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">So? Can I help somehow?</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, Sep 9, 2013 at 8:09 PM, George
Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> The configuration
looks ok. I may be missing something<span><font color="#888888"><br>
</font></span>
<div><span><font color="#888888"><br>
<pre cols="72">George Gastaldi | Senior Software Engineer
JBoss Forge Team
Red Hat
</pre>
</font></span>
<div>
<div> <br>
<br>
-------- Original Message --------
<table border="0" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">Subject: </th>
<td>Git tools</td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">Date: </th>
<td>Mon, 9 Sep 2013 18:34:05 +0300</td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">From: </th>
<td>Ivan St. Ivanov <a href="mailto:ivan.st.ivanov@gmail.com" target="_blank"><ivan.st.ivanov@gmail.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">To: </th>
<td>George Gastaldi <a href="mailto:ggastald@redhat.com" target="_blank"><ggastald@redhat.com></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<div dir="ltr">Hey Gastaldi,
<div><br>
</div>
<div>I have attached an archive of the git-tools
addon together with a small change in the parent
pom (the jgit version).</div>
<div><br>
</div>
<div>As I wrote in the chat, I get the following
error ATM:</div>
<div><br>
</div>
<div>
<div>SEVERE: Failed to start addon
[org.jboss.forge.addon:git-tools,2.0.0-SNAPSHOT]
with classloader [ModuleClassLoader for Module
"org.jboss.forge.addon.git-tools:2.0.0-SNAPSHOT_384942ba-8666-45c0-ae26-3c918c8f6b29"
from AddonModuleLoader]</div>
<div>org.jboss.weld.exceptions.DeploymentException:
WELD-001408 Unsatisfied dependencies for type
[GitIgnoreConfig] with qualifiers [@Default]
at injection point [[BackedAnnotatedField]
@Inject private
org.jboss.forge.addon.git.facet.GitIgnoreFacetImpl.config]</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateInjectionPointForDeploymentProblems(Validator.java:405)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateInjectionPoint(Validator.java:327)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateGeneralBean(Validator.java:178)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateRIBean(Validator.java:209)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateBean(Validator.java:521)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateBeans(Validator.java:507)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.Validator.validateDeployment(Validator.java:482)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.WeldBootstrap.validateBeans(WeldBootstrap.java:538)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.bootstrap.api.helpers.ForwardingBootstrap.validateBeans(ForwardingBootstrap.java:75)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.weld.environment.se.Weld.initialize(Weld.java:144)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.forge.furnace.container.cdi.lifecycle.WeldAddonLifecycleProvider.start(WeldAddonLifecycleProvider.java:59)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.forge.furnace.impl.addons.AddonRunnable$1.call(AddonRunnable.java:77)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.forge.furnace.impl.addons.AddonRunnable$1.call(AddonRunnable.java:71)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34)</div>
<div><span style="white-space:pre-wrap"> </span>at
org.jboss.forge.furnace.impl.addons.AddonRunnable.run(AddonRunnable.java:70)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.util.concurrent.FutureTask.run(FutureTask.java:138)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)</div>
<div><span style="white-space:pre-wrap"> </span>at
java.lang.Thread.run(Thread.java:662)</div>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Ivan</div>
</div>
<br>
</div>
</div>
</div>
<br>
</div>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
forge-dev mailing list
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br>
Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>
"Simpler is better."
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>
</div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>