<div dir="ltr">Hey George,<div><br></div><div>Waiting for your feedback! :)</div><div><br></div><div>About the repository: I don't think that git-tools should be part of the forge core. However, having a separate repository for each addon is a little bit too much for me. Maybe we can stick to the Forge 1 way: have one repository for non-core addons and let the people decide where to put their own. In that repo or in a repo they decide.</div>
<div><br></div><div>Cheers and Happy new year!</div><div>Ivan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Hey Ivan!</div><div><br></div><div>We'll review your code asap. I think also we might create a "git-tools-forge-addon" repository in forge organization to distribute that. Wdyt?</div>
<div><br></div><div>May you and your family also have a happy new year.</div><div><br></div><div>Best Regards,</div><div><br></div><div>George</div><div><br>Em 31/12/2013, às 15:33, "Ivan St. Ivanov" <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br>
<br></div><div><div class="h5"><blockquote type="cite"><div><div dir="ltr">Hi everybody,<div><br></div><div>A few hours before 2013 is over, I am very happy to announce that the git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.</div>
<div><br></div><div>I have transformed the missing functionality and the tests in Forge core addon style: different projects for api, addon, impl (containing the UI commands) and tests. The tests are passing both in Eclipse and in Maven. I have added javadoc to the APIs, README.asciidoc file and some man commands.</div>
<div><br></div><div>I haven't yet issued a pull request for two reasons:</div><div><br></div><div>* I am not sure whether you will want git-tools in the core repository or you may want it in another one</div><div>* I expect some feedback from your side on my work</div>
<div><br></div><div>You can access the addon code here: <a href="https://github.com/ivannov/core/tree/FORGE-1128" target="_blank">https://github.com/ivannov/core/tree/FORGE-1128</a>. Once you build it and install it in your local maven repository (Java 7 and Maven 3.1 required), you may install it by simply running (FORGE_HOME should be set to Forge 2):</div>
<div><br></div><div>forge --install git-tools</div><div><br></div><div>You can review the functionality in the README file:</div><div><br></div><div><a href="https://github.com/ivannov/core/tree/FORGE-1128/git-tools" target="_blank">https://github.com/ivannov/core/tree/FORGE-1128/git-tools</a><br>
</div><div><br></div><div>As I have promised, I will send my feedback about the development experience in Forge 2. I will also give you some feedback on the command line shell usage on Windows (and maybe add some JIRAs to Antonio's list). And, Lincoln, I haven't forgot this: <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230" target="_blank">https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230</a>. </div>
<div><br></div><div>At the end, I wish all of you and your families a very happy, healthy and successful 2014!</div><div><br></div><div>Cheers,</div><div>Ivan</div><div><br></div><div><br></div></div>
</div></blockquote></div></div><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br>
<span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>