<div dir="ltr">Hey George,<div><br></div><div>Thanks for that! I pushed my addon to the FORGE-1128 branch there: <a href="https://github.com/forge/addon-git/tree/FORGE-1128">https://github.com/forge/addon-git/tree/FORGE-1128</a></div>
<div><br></div><div>I didn't know where did you want it: master, 2.0... So I used the feature branch.</div><div><br></div><div>Cheers,</div><div>Ivan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Jan 7, 2014 at 7:47 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I created the repository <a href="https://github.com/forge/addon-git" target="_blank">https://github.com/forge/addon-git</a> and gave you the necessary permissions to push. Could you move it to this repository?<br>
Thanks!<br>
<div class="im"><br>
----- Original Message -----<br>
From: "Ivan St. Ivanov" <<a href="mailto:ivan.st.ivanov@gmail.com">ivan.st.ivanov@gmail.com</a>><br>
To: "forge-dev List" <<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a>><br>
Sent: Wednesday, January 1, 2014 9:28:27 AM<br>
Subject: Re: [forge-dev] The git-tools addon<br>
<br>
Hey George,<br>
<br>
Waiting for your feedback! :)<br>
<br>
About the repository: I don't think that git-tools should be part of the forge core. However, having a separate repository for each addon is a little bit too much for me. Maybe we can stick to the Forge 1 way: have one repository for non-core addons and let the people decide where to put their own. In that repo or in a repo they decide.<br>
<br>
Cheers and Happy new year!<br>
Ivan<br>
<br>
<br>
On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi < <a href="mailto:ggastald@redhat.com">ggastald@redhat.com</a> > wrote:<br>
<br>
<br>
<br>
Hey Ivan!<br>
<br>
We'll review your code asap. I think also we might create a "git-tools-forge-addon" repository in forge organization to distribute that. Wdyt?<br>
<br>
May you and your family also have a happy new year.<br>
<br>
Best Regards,<br>
<br>
George<br>
<br>
Em 31/12/2013, ās 15:33, "Ivan St. Ivanov" < <a href="mailto:ivan.st.ivanov@gmail.com">ivan.st.ivanov@gmail.com</a> > escreveu:<br>
<br>
<br>
<br>
<br>
Hi everybody,<br>
<br>
A few hours before 2013 is over, I am very happy to announce that the git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.<br>
<br>
I have transformed the missing functionality and the tests in Forge core addon style: different projects for api, addon, impl (containing the UI commands) and tests. The tests are passing both in Eclipse and in Maven. I have added javadoc to the APIs, README.asciidoc file and some man commands.<br>
<br>
I haven't yet issued a pull request for two reasons:<br>
<br>
* I am not sure whether you will want git-tools in the core repository or you may want it in another one<br>
* I expect some feedback from your side on my work<br>
<br>
</div>You can access the addon code here: <a href="https://github.com/ivannov/core/tree/FORGE-1128" target="_blank">https://github.com/ivannov/core/tree/FORGE-1128</a> . Once you build it and install it in your local maven repository (Java 7 and Maven 3.1 required), you may install it by simply running (FORGE_HOME should be set to Forge 2):<br>
<div class="HOEnZb"><div class="h5"><br>
forge --install git-tools<br>
<br>
You can review the functionality in the README file:<br>
<br>
<a href="https://github.com/ivannov/core/tree/FORGE-1128/git-tools" target="_blank">https://github.com/ivannov/core/tree/FORGE-1128/git-tools</a><br>
<br>
As I have promised, I will send my feedback about the development experience in Forge 2. I will also give you some feedback on the command line shell usage on Windows (and maybe add some JIRAs to Antonio's list). And, Lincoln, I haven't forgot this: <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230" target="_blank">https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230</a> .<br>
<br>
At the end, I wish all of you and your families a very happy, healthy and successful 2014!<br>
<br>
Cheers,<br>
Ivan<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></div></div></blockquote></div><br></div>