<div dir="ltr">I think it was possible to do that in Forge 1?<div><br></div><div>BTW, how do you get a project name from the Project object? Is it through the Maven facet? Do we always have that on a project?</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Sun, Jan 26, 2014 at 12:06 AM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="auto"><div>I'd rather pass as a param than injecting tbh. This allows the object to be reused as a singleton without aby thread issues.</div><div><br></div><div>Btw Project is not yet available for injection. Should we create a JIRA for it?</div>
<div><br>Em 25/01/2014, ās 20:02, "Ivan St. Ivanov" <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br><br></div><div><div class="h5"><blockquote type="cite">
<div><div dir="ltr">OK, but what does the JavaEEDefaultProvider::configure method do? It produces the content of persistence.xml. Why would you need Project object to pollute the interface if it's used in just one of the implementations? And we can even do without it, as you noted.<div>
<br></div><div>When I asked this question in the first message of this thread, I was thinking of somehow injecting the project, not changing the interface.</div><div><br></div><div>But if you say it's reasonable, I will do that, it's not a big deal.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jan 25, 2014 at 11:00 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>However since we are on CR1, and other requirements may appear, perhaps it's wise to change the interface definition now than later. :)</div>
<div><br>Em 25/01/2014, ās 18:58, "Ivan St. Ivanov" <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br><br></div><div><div><blockquote type="cite">
<div><div dir="ltr">Thanks, George! <div><br></div><div>As I am not really keen to change the interface definition, I would do it as you proposed: without the project name.<div><br></div><div>Cheers,</div><div>Ivan</div>
</div>
</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jan 25, 2014 at 10:52 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Hey Ivan,</div><div>You could change the configure method signature to pass the project as a parameter, but remember that it may be null.</div>
<div><br></div><div>However, I think it would be better to not add the projectName to the DDL file in order to keep it simple and easier to find.</div><div><br></div><div>Best Regards,</div><div><br></div><div>George Gastaldi</div>
<div><br>Em 25/01/2014, ās 18:42, "Ivan St. Ivanov" <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br><br></div><div><div><blockquote type="cite">
<div><div dir="ltr">Hi folks,<div><br></div><div>I am working on <a href="https://issues.jboss.org/browse/FORGE-1443" target="_blank">https://issues.jboss.org/browse/FORGE-1443</a>. It's not a big deal, it's a matter of adding a few lines to the JavaEEDefaultProvider class.</div>
<div><br></div><div>One of the requirements is that the create and drop scripts should bear the name of the project: <projectName>Creade.ddl and <projectName>Drop.ddl. I wonder is there a way to pass that somehow to the persistence provider?</div>
<div><br></div><div>Thanks,</div><div>Ivan</div></div>
</div></blockquote></div></div><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br>
<span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br>
<span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div></div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br>
<span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div></div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>