<div dir="ltr">Yeah, we may leave the IllegalArgumentException and just add another catch clause for RuntimeException</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 3:14 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>That is a good idea, but I guess also that we should not wrap the IllegalArgumentException thrown in MavenAddonDependencyResolver.</div><div><br>Best Regards,</div><div><br></div><div>George Gastaldi</div><div><br>Em 03/01/2015, às 11:09, Ivan St. Ivanov <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br><br></div><div><div class="h5"><blockquote type="cite"><div><div dir="ltr">Hi folks,<div><br></div><div>George, we are talking here about Soro's issue, the one that you reported in the JIRA. About mine, you were right that the environment variable was not set.</div><div><br></div><div>I guess that the validator *is* called. At least from the stack trace in the JIRA, I see that the error happens while calling the AbstractUICommand validate method. Most probably the exception escapes and just gets logged.</div><div><br></div><div>Maybe if you add catch clause for a RuntimeException to the validator, it will work.</div><div><br></div><div>Cheers,</div><div>Ivan</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 3:03 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Hi Ivan,</div><div><br></div><div>That's because the code is on the Bootstrap class (see the stacktrace you pasted). As for the UIValidator not being called, I'll investigate further.<br><br><br></div><div><br>Em 03/01/2015, às 10:51, Ivan St. Ivanov <<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>> escreveu:<br><br></div><div><div><blockquote type="cite"><div><div dir="ltr">Hi folks,<div><br></div><div><b>George</b>, most probably that was the reason.</div><div><br></div><div>I don't quite understand the problem described in this issue. Is it because there is a validation error but there is no popup in the IDE and just something in the logs? Then I guess this could be fixed if the exception that is caught <a href="https://github.com/forge/core/blob/master/addon-manager/impl/src/main/java/org/jboss/forge/addon/manager/impl/ui/AddonInstallCommand.java#L98" target="_blank">here</a> is changed to RuntimeException or if we add a new catch block for RuntimeException with different validation error.</div><div><br></div><div>WDYT?</div><div><br></div><div>Cheers,</div><div>Ivan</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 2:36 PM, Daniel Cunha <span dir="ltr"><<a href="mailto:danielsoro@gmail.com" target="_blank">danielsoro@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Ivan,</div><div><br></div><div>I'm looking for it. George opened a issue for it. (<a href="https://issues.jboss.org/browse/FORGE-2169" target="_blank">https://issues.jboss.org/browse/FORGE-2169</a>).</div><div><a href="http://maven.apache.org/pom.html#Maven_Coordinates" target="_blank">http://maven.apache.org/pom.html#Maven_Coordinates</a></div><div><br></div><div>I think that this "," (comma) not should to exist. Ok?</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 12:28 PM, Ivan St. Ivanov <span dir="ltr"><<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Soro,<div><br></div><div>I guess upon executing the addon install command (prior to the actual execution).</div><div><br></div><div>Did you also get an error when trying to run:</div><div><br></div><div>forge --install org.jboss.forge.addon:core,$FORGE_VERSION<br></div><div><br></div><div>This morning I got:</div><div><br></div><div><div>java.lang.IllegalArgumentException: Coordinates must be of the form 'name,version' or 'name,version,api-version</div><div><span style="white-space:pre-wrap"> </span>at org.jboss.forge.furnace.addons.AddonId.fromCoordinates(AddonId.java:78)</div><div><span style="white-space:pre-wrap"> </span>at org.jboss.forge.bootstrap.Bootstrap.install(Bootstrap.java:311)</div><div><span style="white-space:pre-wrap"> </span>at org.jboss.forge.bootstrap.Bootstrap.<init>(Bootstrap.java:179)</div><div><span style="white-space:pre-wrap"> </span>at org.jboss.forge.bootstrap.Bootstrap.main(Bootstrap.java:95)</div></div><div><br></div><div>However, I did not investigate much into it. I guess I have to change the `:core` part in my script to `,core`. </div><div><br></div><div>Cheers,</div><div>Ivan</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Sat, Jan 3, 2015 at 2:19 PM, Daniel Cunha <span dir="ltr"><<a href="mailto:danielsoro@gmail.com" target="_blank">danielsoro@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div>When this validation is called?</div><div><a href="https://github.com/forge/core/blob/master/addon-manager/impl/src/main/java/org/jboss/forge/addon/manager/impl/ui/AddonInstallCommand.java#L88-L107" target="_blank">https://github.com/forge/core/blob/master/addon-manager/impl/src/main/java/org/jboss/forge/addon/manager/impl/ui/AddonInstallCommand.java#L88-L107</a></div><span><font color="#888888"><div><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12px;color:rgb(0,0,0)">Daniel Cunha (soro)</span></div></div></div></div></div>
</div></font></span></div>
<br></div></div>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12px;color:rgb(0,0,0)">Daniel Cunha (soro)</span></div></div></div></div></div>
</font></span></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div></div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></div></div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>