<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Antonio,</div><div><br></div><div>How different is that from the immutable Map? I find the Map more flexible in terms of:</div><div><br></div><div>- you can do inputs.keySet() and iterate through the input names (there are some places where we do this)</div><div>- some UIProviders need to know if a Command has any input at all to decide if it should execute or should render the Wizard screen.</div><div><br></div><div>So I am not sure if this is a good idea, but I may be wrong ;)</div><div><br></div><div>Best Regards,</div><div><br></div><div>George Gastaldi<br><br><br></div><div><br>Em 19/02/2015, às 07:24, Antonio Goncalves <<a href="mailto:antonio.mailing@gmail.com">antonio.mailing@gmail.com</a>> escreveu:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra">Hi all,</div><div class="gmail_extra"><br></div><div class="gmail_extra">I'm investigating how to refactor UICommands in the best way (see the analysis in <a href="https://issues.jboss.org/browse/FORGE-2109">https://issues.jboss.org/browse/FORGE-2109</a>). But before refactoring, I would like to add a stronger test coverage so I make sure I don't break things. </div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">I was looking at CommandController that list of the command inputs : </div><div class="gmail_extra"><br></div><div class="gmail_extra"><font face="monospace, monospace">Map<String, InputComponent<?, ?>> <b>getInputs</b>();</font></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">I would like to add the following commands </div><div class="gmail_extra"><br></div><div class="gmail_extra"><font face="monospace, monospace">InputComponent<?, ?> <b>getInput</b>(String input); // returns one input</font></div><div class="gmail_extra"><font face="monospace, monospace">boolean <b>hasInput</b>(String input); // checks if the input is present</font><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">What do you think ?</div><div class="gmail_extra"><div><br></div>-- <br><div class="gmail_signature">Antonio Goncalves <br>Software architect and Java Champion<br><br><a href="http://www.antoniogoncalves.org/" target="_blank">Web site</a> | <a href="http://twitter.com/agoncal" target="_blank">Twitter</a> | <a href="http://www.linkedin.com/in/agoncal" target="_blank">LinkedIn</a> | <a href="http://www.parisjug.org/" target="_blank">Paris JUG</a> | <a href="http://www.devoxx.fr/" target="_blank">Devoxx France</a></div>
</div></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></body></html>