<p dir="ltr">Maybe if you have a custom stack that needs the JavaEE7 dependency but runs as a Microservice?</p>
<div class="gmail_quote">Em 12/01/2016 20:04, "Lincoln Baxter, III" <<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>> escreveu:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmmmmm.... Is there a down side to that scenario? (The stack being activated?)</div><div class="gmail_extra"><br clear="all"><div><div>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."</div></div>
<br><div class="gmail_quote">On Mon, Jan 11, 2016 at 10:14 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Yes, I did and I refactored the code removing the duplicated part. Thank you for reviewing it. I think that adding a new annotation wouldn't help much, therefore I added a new protected method in AbstractProjectCommand to do the filtering (we can discuss this in the next meeting).</p>
<p dir="ltr">However there is one thing that hit my mind: by making the JavaEE7FacetImpl a StackFacet, it doesn't matter if I have another stack, the JavaEE 7 stack will always be activated when the JavaEE 7 dependencies are set in the pom.xml.</p>
<p dir="ltr">Perhaps I should store the stack information used in the project as part of the project configuration (by using the ConfigurationFacet)?</p><div><div>
<div class="gmail_quote">Em 12/01/2016 00:42, "Lincoln Baxter, III" <<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>> escreveu:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Did you see my comments on github?</div><div class="gmail_extra"><br clear="all"><div><div>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."</div></div>
<br><div class="gmail_quote">On Mon, Jan 11, 2016 at 4:53 PM, George Gastaldi <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div>Hello Forgers!<br><br></div>I would really appreciate your feedback on the Forge Stacks support. I have provided a pull-request (<a href="https://github.com/forge/core/pull/592" target="_blank">https://github.com/forge/core/pull/592</a>) that I want to merge still this week with the changes.<br><br></div>I still need to document this feature, but it basically does what is described in <a href="https://issues.jboss.org/browse/FORGE-2316" target="_blank">https://issues.jboss.org/browse/FORGE-2316</a> <br><br></div>Regarding to the implementation details, I created a StacksFacet interface (that's supposed to be implemented if you want to add a new stack) that returns a Stack object (that is in charge of deciding if a given ProjectFacet is supported). Stacks are built using the StackBuilder class. <br></div><div>I have added a --stack option in the project-new command that just calls the StackFacet.install() method. In order to find the facet bound to the project it is simply a matter of calling: <br><br></div><div>project.getFacet(StackFacet.class).<br></div><div><br></div><div>Let me know if you have any questions. I'd be more than happy to answer.<span><font color="#888888"><br></font></span></div><span><font color="#888888"><div><div><div><div><div><div><div><div><div><div><div><br>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><b>George Gastaldi</b><br><br><a href="https://about.me/gastaldi" target="_blank">https://about.me/gastaldi</a><br></div></div></div></div></div></div>
</div></div></div></div></div></div></div></div></div></div></div></font></span></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div>
</div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div>