[forge-issues] [JBoss JIRA] (FORGE-1407) Shell is missing options in wizards where default values allow immediately moving to next step

[Lincoln Baxter III (JIRA)]

Lincoln Baxter III created FORGE-1407:
-----------------------------------------

             Summary: Shell is missing options in wizards where default values allow immediately moving to next step
                 Key: FORGE-1407
                 URL: https://issues.jboss.org/browse/FORGE-1407
             Project: Forge
          Issue Type: Feature Request
          Components: UI - Shell
    Affects Versions: 2.0.0.Beta4
            Reporter: Lincoln Baxter III


Should have a lot more options:

{code}
[jpa-demo]$ jpa-setup 
--dataSourceName  --dbType  --persistenceUnitName 
{code}

The problem is here in ShellWizard.java (in shell addon)

{code}
 private CommandLineParser populate(ShellContext shellContext, String line,

            final Map<String, InputComponent<?, ?>> inputs)

            throws Exception

   {

      inputs.putAll(getController().getInputs());

      CommandLineParser parser = commandLineUtil.generateParser(getController(), shellContext, inputs);

      CommandLine cmdLine = parser.parse(line, true);

      Map<String, InputComponent<?, ?>> populatedInputs = commandLineUtil.populateUIInputs(cmdLine, inputs);

      if (getController().isValid())

      {

         if (getController().canMoveToNextStep())

         {

            // The bug is here. we are immediately moving to the next step and removing all inputs that are not populated.

            // this really needs to know if we have defaulted to next step or actually moved there willingly

            // it should not remove old choices until a new choice has been made

            getController().next().initialize();

            inputs.keySet().retainAll(populatedInputs.keySet());

            parser = populate(shellContext, line, inputs);

         }

      }

      return parser;

   }
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira