[forge-issues] [JBoss JIRA] (FORGE-150) Implementations of JavaParser Interfaces should maintain equality with other implementations

[George Gastaldi (JIRA)]

     [ https://issues.jboss.org/browse/FORGE-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Gastaldi updated FORGE-150:
----------------------------------

        Status: Closed  (was: Pull Request Sent)
    Resolution: Done


Merged, thanks !
                
> Implementations of JavaParser Interfaces should maintain equality with other implementations
> --------------------------------------------------------------------------------------------
>
>                 Key: FORGE-150
>                 URL: https://issues.jboss.org/browse/FORGE-150
>             Project: Forge
>          Issue Type: Enhancement
>          Components: Parsers / File Manipulation
>    Affects Versions: 1.0.0.Alpha4
>            Reporter: Jason Porter
>            Assignee: Ivan St. Ivanov
>             Fix For: 1.2.1.Final
>
>
> Until I saw how to create an Import (which I still don't agree with having to be tied to the Implementation) I thought about creating my own implementation for a test (a mock would be even better) so I looked at the equals for the ImportImpl and it does not keep equality with other implementations because it checks to see if the class is the same. It also checks internal state instead of using the interface methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira