[forge-issues] [JBoss JIRA] (FORGE-85) Shell cannot parse command values containing '!' exclaimation points

[Vineet Reynolds (JIRA)]

    [ https://issues.jboss.org/browse/FORGE-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789531#comment-12789531 ] 

Vineet Reynolds commented on FORGE-85:
--------------------------------------

Escaping of exclamation marks was fixed upstream in jline2, a few months back. I've ported it to a topic branch on my clone: https://github.com/VineetReynolds/forge-core/tree/FORGE-85.

But this alone does not solve the problem yet. The FSH parser tokenizes '!'s differently. Thus, a command invocation provided to the parser, like {{new-project --named example --finalName example!test}}, is turned into {{new-project --named example --finalName example ! test}}. The tokens '!' and 'test' are eventually ignored as arguments to the new-project plugin, due to the spaces injected by the FSH parser.
                
> Shell cannot parse command values containing '!' exclaimation points
> --------------------------------------------------------------------
>
>                 Key: FORGE-85
>                 URL: https://issues.jboss.org/browse/FORGE-85
>             Project: Forge
>          Issue Type: Bug
>          Components: UI - Shell
>    Affects Versions: 1.0.0.Beta2
>            Reporter: Lincoln Baxter III
>              Labels: HackNight
>             Fix For: 1.x Future
>
>         Attachments: Forge-85.patch
>
>
> {code}
> [pfdemo] pfdemo $ echo sdfdf!
> sdfdf !
> [pfdemo] pfdemo $ echo sdfdf!sdf
> ***ERROR*** Exception encountered: !sdf: event not found (type "set VERBOSE true" to enable stack traces)
> [pfdemo] pfdemo $ 
> [pfdemo] pfdemo $ echo 'asdf!asdf`
> ***ERROR*** Exception encountered: !asdf`: event not found (type "set VERBOSE true" to enable stack traces)
> [pfdemo] pfdemo $ 
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira