[forge-issues] [JBoss JIRA] (ROASTER-5) Having method parameters a bit more typed

Matt Benson (JIRA) issues at jboss.org
Fri Apr 4 11:58:12 EDT 2014


    [ https://issues.jboss.org/browse/ROASTER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12959394#comment-12959394 ] 

Matt Benson commented on ROASTER-5:
-----------------------------------

I can see how Antonio's requested syntax could be nice, but Roaster's other similar APIs work the way George has described, so for consistency's sake this would be best.
                
> Having method parameters a bit more typed
> -----------------------------------------
>
>                 Key: ROASTER-5
>                 URL: https://issues.jboss.org/browse/ROASTER-5
>             Project: Roaster
>          Issue Type: Feature Request
>          Components: API
>    Affects Versions: 2.1.0.Final
>            Reporter: Antonio Goncalves
>             Fix For: 2.x Future
>
>
> I want to create a Bean Validation implementation, that means that the {{isValid}} method takes two parameters. And the only way to add two parameters seems to be by a String
> {code}
> javaClass.addMethod().setPublic().setName("isValid").setReturnType("boolean").setParameters("Number value, ConstraintValidatorContext context").setBody("return false;").addAnnotation(Override.class);
> {code}
> It would be nice to have typed parameters so the import is implicit, and things are a bit more typed :
> {code}
> javaClass.addMethod().setPublic().setName("isValid").setReturnType("boolean").addParameter(Number.class, "value").addParameter(ConstraintValidatorContext.class, "context").setBody("return false;").addAnnotation(Override.class);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the forge-issues mailing list