[forge-issues] [JBoss JIRA] (FORGE-1698) MavenJavaCompilerFacet should use user properties instead of declaring the compiler plugin

[Matej Briskar (JIRA)]

    [ https://issues.jboss.org/browse/FORGE-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12962017#comment-12962017 ] 

Matej Briskar commented on FORGE-1698:
--------------------------------------

ah sorry, overlooked the closed status.
                
> MavenJavaCompilerFacet should use user properties instead of declaring the compiler plugin
> ------------------------------------------------------------------------------------------
>
>                 Key: FORGE-1698
>                 URL: https://issues.jboss.org/browse/FORGE-1698
>             Project: Forge
>          Issue Type: Enhancement
>          Components: Build Tools - Maven
>    Affects Versions: 2.3.0.Final
>            Reporter: George Gastaldi
>            Assignee: George Gastaldi
>            Priority: Minor
>              Labels: Starter
>             Fix For: 2.4.1.Final
>
>
> The current {{org.jboss.forge.addon.maven.projects.facets.MavenJavaCompilerFacet}} declares a compiler plugin with the parameters: 
> {code}
>       <plugin>
>         <artifactId>maven-compiler-plugin</artifactId>
>         <version>3.1</version>
>         <configuration>
>           <source>1.7</source>
>           <target>1.7</target>
>           <encoding>UTF-8</encoding>
>         </configuration>
>       </plugin>
> {code}
> As per http://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html, this could be changed to: 
> {code}
> <properties>
>     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>     <maven.compiler.source>1.7</maven.compiler.source>
>     <maven.compiler.target>1.7</maven.compiler.target>
> </properties>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira