[forge-issues] [JBoss JIRA] (ROASTER-10) Auto generated imports when a field type is set causes .java file to not compile.

[Walter Medvedeo (JIRA)]

    [ https://issues.jboss.org/browse/ROASTER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964271#comment-12964271 ] 

Walter Medvedeo commented on ROASTER-10:
----------------------------------------

I agree that to overload the method adding the boolean on/off version is not elegant.
But I believe it gives the opportunity to have more control over whats happening with the class, and this can be useful in some scenarios.
                
> Auto generated imports when a field type is set causes .java file to not compile.
> ---------------------------------------------------------------------------------
>
>                 Key: ROASTER-10
>                 URL: https://issues.jboss.org/browse/ROASTER-10
>             Project: Roaster
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 2.2.0.Final
>            Reporter: Walter Medvedeo
>
> When we set the Type for a given field using the FieldSource.setType( X ) methods an import is generated automatically.
> Under some situations it causes the resulting class to not compile and it's not posible to fix it using the api.
> In order to avoid this, and also to be able to modify a given class in a more "safe or controlled" way (for example in cases when we don't want to manage complex refactorings or controlling imports), It's desirable to have setType( X, boolean addImports) method that just change the field type to the provided type name and don't add imports.
> e.g:
> Given the following declaration:
> private org.test.Class1 myField;
> myField.setType("org.somepackage.Class2", false) 
> will produce the following result:
> private org.somepackage.Class2 myField;
> and:
> myField.setType("Class2", false)
> will produce the following result:
> private Class2 myField.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira