[forge-issues] [JBoss JIRA] (FORGE-1553) DefaultShellTest is not fully compatible with Results from a Wizard execution

George Gastaldi (JIRA) issues at jboss.org
Tue Feb 4 15:50:29 EST 2014


     [ https://issues.jboss.org/browse/FORGE-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Gastaldi updated FORGE-1553:
-----------------------------------

    Description: 
When a wizard is executed, the postCommandExecuted is called for each step in the Wizard. This leads to the invocation of {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.postCommandExecuted(UICommand, UIExecutionContext, Result)}} several times.

The {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.isExecuted()}}  method should be reviewed, since the current impl may return true even if the command has not finished execution

  was:
When a wizard is executed, the postCommandExecuted is called for each step in the Wizard. This leads to multiple invocation of {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.postCommandExecuted(UICommand, UIExecutionContext, Result)}} several times.

The {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.isExecuted()}}  method should be reviewed, since the current impl may return true even if the command has not finished execution


    
> DefaultShellTest is not fully compatible with Results from a Wizard execution
> -----------------------------------------------------------------------------
>
>                 Key: FORGE-1553
>                 URL: https://issues.jboss.org/browse/FORGE-1553
>             Project: Forge
>          Issue Type: Bug
>          Components: Test Harness
>    Affects Versions: 2.0.0.Final
>            Reporter: George Gastaldi
>             Fix For: 2.x Future
>
>
> When a wizard is executed, the postCommandExecuted is called for each step in the Wizard. This leads to the invocation of {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.postCommandExecuted(UICommand, UIExecutionContext, Result)}} several times.
> The {{org.jboss.forge.addon.shell.test.impl.DefaultShellTest.TestCommandListener.isExecuted()}}  method should be reviewed, since the current impl may return true even if the command has not finished execution

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the forge-issues mailing list