[forge-issues] [JBoss JIRA] (FORGE-1597) Optional facets are preventing installation of facets

[George Gastaldi (JIRA)]

     [ https://issues.jboss.org/browse/FORGE-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Gastaldi updated FORGE-1597:
-----------------------------------

              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/forge/core/pull/390

    
> Optional facets are preventing installation of facets
> -----------------------------------------------------
>
>                 Key: FORGE-1597
>                 URL: https://issues.jboss.org/browse/FORGE-1597
>             Project: Forge
>          Issue Type: Bug
>          Components: Plugin API
>    Affects Versions: 2.0.0.Final
>            Reporter: George Gastaldi
>            Priority: Blocker
>             Fix For: 2.0.1.Final
>
>
> FacesFacet declares an optional constraint on ServletFacet. FacetFactoryImpl checks if the optional constraint is satisfied in https://github.com/forge/core/blob/master/facets/impl/src/main/java/org/jboss/forge/addon/facets/FacetFactoryImpl.java#L306 , hence not registering the candidate facet. 
> This test summarizes the problem (in 
> {{org.jboss.forge.addon.javaee.faces.FacesFacetTest}}): 
> {code}
>    @Test
>    public void testFacesFacetInstalledAfterProjectIsEvictedFromCache()
>    {
>       Project project = projectFactory.createTempProject();
>       facetFactory.install(project, FacesFacet_2_2.class);
>       Assert.assertTrue("Should have FacesFacet", project.hasFacet(FacesFacet.class));
>       Assert.assertTrue("Should have FacesFacet_2_2", project.hasFacet(FacesFacet_2_2.class));
>       projectFactory.invalidateCaches();
>       project = projectFactory.findProject(project.getRootDirectory());
>       Assert.assertTrue("Should have FacesFacet", project.hasFacet(FacesFacet.class));
>       Assert.assertTrue("Should have FacesFacet_2_2", project.hasFacet(FacesFacet_2_2.class));
>    }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira