[forge-issues] [JBoss JIRA] (FORGE-2154) Cannot add two dependencies that differ only in the 'type' attribute to a new Maven project's POM.

[George Gastaldi (JIRA)]

    [ https://issues.jboss.org/browse/FORGE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022510#comment-13022510 ] 

George Gastaldi edited comment on FORGE-2154 at 11/24/14 10:51 PM:
-------------------------------------------------------------------

I believe the code you're referring to is https://github.com/forge/core/blob/master/maven/impl-projects/src/main/java/org/jboss/forge/addon/maven/projects/facets/MavenDependencyFacet.java#L76 ?


was (Author: gastaldi):
I believe the class you're referring to is https://github.com/forge/core/blob/master/maven/impl-projects/src/main/java/org/jboss/forge/addon/maven/projects/facets/MavenDependencyFacet.java ?

> Cannot add two dependencies that differ only in the 'type' attribute to a new Maven project's POM.
> --------------------------------------------------------------------------------------------------
>
>                 Key: FORGE-2154
>                 URL: https://issues.jboss.org/browse/FORGE-2154
>             Project: Forge
>          Issue Type: Bug
>          Components: Addon Development
>    Affects Versions: 2.12.2.Final
>            Reporter: Divya Dadlani
>            Assignee: George Gastaldi
>             Fix For: 2.12.3.Final
>
>
> The method "areEquivalent(Dependency, Dependency)" of org.jboss.forge.addon.dependencies.util.Dependencies does not check to see if the two dependencies have different packaging types or scopes.
> For example, I cannot add both of the following dependencies:
> <dependency>
>   <groupId>org.jboss.errai</groupId>
>   <artifactId>errai-cdi-client</artifactId>
>   <type>jar</type>
>   <scope>provided</scope>
> </dependency>
> <dependency>
>   <groupId>org.jboss.errai</groupId>
>   <artifactId>errai-cdi-client</artifactId>
>   <type>test-jar</type>
>   <scope>test</scope>
> </dependency>



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)