[forge-issues] [JBoss JIRA] (FORGE-2419) Refactoring the JSF Commands

[George Gastaldi (JIRA)]

     [ https://issues.jboss.org/browse/FORGE-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Gastaldi closed FORGE-2419.
----------------------------------
    Fix Version/s: 2.17.1.Final
                       (was: 2.x Future)
       Resolution: Done


> Refactoring the JSF Commands
> ----------------------------
>
>                 Key: FORGE-2419
>                 URL: https://issues.jboss.org/browse/FORGE-2419
>             Project: Forge
>          Issue Type: Sub-task
>          Components: Java EE
>    Affects Versions: 2.17.0.Final
>            Reporter: Antonio Goncalves
>            Assignee: Antonio Goncalves
>             Fix For: 2.17.1.Final
>
>
> Today the JSF methods {{FacesNewBeanCommand}}, {{FacesNewConverterCommand}} and {{FacesNewValidatorCommand}} use templating. 
> For the little amount of code that is generated, it would be better to use Roaster instead. And in the refactoring process, add some tests.
> Today the JSF commands have the following hierarchy :
> {code}
> AbstractUICommand implements UICommand
>     AbstractProjectCommand 
>         AbstractJavaEECommand
>             AbstractFacesCommand implements PrerequisiteCommandsProvider
>                 FacesNewBeanCommand implements PrerequisiteCommandsProvider
>                 FacesNewConverterCommand
>                 FacesNewValidatorCommand
> {code}
> But most of the other Java EE commands extend {{AbstractJavaSourceCommand}} and not {{AbstractJavaEECommand}}
> {code}
> AbstractUICommand implements UICommand
>     AbstractProjectCommand
>         AbstractJavaSourceCommand<SOURCETYPE extends JavaSource<?>>
>             AbstractCDICommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
>                 CDINewBeanCommand
>                 CDINewDecoratorCommand
>                 CDINewExtensionCommand
>             AbstractJPACommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
>                 JPANewEntityCommand
>                 JPANewEntityListenerCommand
>                 JPANewMappedSuperclassCommand
>             AbstractServletNewCommand<T extends JavaSource<?>> implements PrerequisiteCommandsProvider
>                 ServletNewServletCommand
>                 ServletNewFilterCommand
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)