[forge-issues] [JBoss JIRA] (FORGE-2230) CoordinateBuilder should set null for empty parts of G:A:P:C:V

[Ondrej Zizka (JIRA)]

    [ https://issues.jboss.org/browse/FORGE-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039540#comment-13039540 ] 

Ondrej Zizka edited comment on FORGE-2230 at 2/11/15 10:01 AM:
---------------------------------------------------------------

Currently, parsing only "G:A:V" returns an object with getPackaging() returning null.
I recommend returning null instead of empty strings to avoid both inconsistency and behavior change (unless behavior can change in Forge across minor versions).


was (Author: ozizka):
Currently, parsing only "G:A:V" returns an object with getPackaging() returning null.
I recommend returning null instead of empty strings to avoid inconsistency and behavior change (unless those do not matter in Forge).

> CoordinateBuilder should set null for empty parts of G:A:P:C:V
> --------------------------------------------------------------
>
>                 Key: FORGE-2230
>                 URL: https://issues.jboss.org/browse/FORGE-2230
>             Project: Forge
>          Issue Type: Enhancement
>          Components: Dependencies
>    Affects Versions: 2.14.0.Final
>            Reporter: Ondrej Zizka
>
> CoordinateBuilder, when given "G:A:::V", should set P and C to null. Having them empty strings is no good.
> Consider machine-provided lists contaning:
>      org.foo:foo-bar:::4.1.2
> This should end with the same result as parsing
>      org.foo:foo-bar:4.1.2
> whereas it ends up with P and C set to empty strings, and forces the user of the api to do extra check for an empty string value.
> Related: 
> "Malformed coordinate. Should be groupId:artifactId:[packaging]:[classifier]:[version]");
> should read
> "Malformed coordinate. Should be groupId:artifactId:[packaging:[classifier:]][version]");
> And javadoc's
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:<version>
> should read
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:[<version>]



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)