[forge-issues] [JBoss JIRA] (FORGE-2230) CoordinateBuilder should set null for empty parts of G:A:P:C:V

[Lincoln Baxter III (JIRA)]

    [ https://issues.jboss.org/browse/FORGE-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039557#comment-13039557 ] 

Lincoln Baxter III edited comment on FORGE-2230 at 2/11/15 10:20 AM:
---------------------------------------------------------------------

.isEmpty() is not a significant performance improvement and is not worth replacing with returning null. The bad practice of causing NPEs is *much* more harmful than a little extra code, particularly in a place where performance really does not matter until you get to the N of millions.


was (Author: lincolnthree):
.isEmpty() is not a significant performance improvement and is NOT worth replacing with returning null. The bad practice of causing NPEs is MUCH more harmful than a little extra code, particularly in a place where performance really does not matter until you get to the N of millions.

> CoordinateBuilder should set null for empty parts of G:A:P:C:V
> --------------------------------------------------------------
>
>                 Key: FORGE-2230
>                 URL: https://issues.jboss.org/browse/FORGE-2230
>             Project: Forge
>          Issue Type: Enhancement
>          Components: Dependencies
>    Affects Versions: 2.14.0.Final
>            Reporter: Ondrej Zizka
>              Labels: starter
>             Fix For: 2.x Future
>
>
> CoordinateBuilder, when given "G:A:::V", should set P and C to null. Having them empty strings is no good.
> Consider machine-provided lists contaning:
>      org.foo:foo-bar:::4.1.2
> This should end with the same result as parsing
>      org.foo:foo-bar:4.1.2
> whereas it ends up with P and C set to empty strings, and forces the user of the api to do extra check for an empty string value.
> Related: 
> "Malformed coordinate. Should be groupId:artifactId:[packaging]:[classifier]:[version]");
> should read
> "Malformed coordinate. Should be groupId:artifactId:[packaging:[classifier:]][version]");
> And javadoc's
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:<version>
> should read
> <groupId>:<artifactId>[:<packaging>[:<classifier>]]:[<version>]



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)