[forge-issues] [JBoss JIRA] (FURNACE-53) MavenContainer always outputs the transfer info to System.out

[George Gastaldi (JIRA)]

     [ https://issues.jboss.org/browse/FURNACE-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Gastaldi closed FURNACE-53.
----------------------------------
    Resolution: Done


> MavenContainer always outputs the transfer info to System.out
> -------------------------------------------------------------
>
>                 Key: FURNACE-53
>                 URL: https://issues.jboss.org/browse/FURNACE-53
>             Project: Forge: Furnace
>          Issue Type: Bug
>          Components: Maven
>    Affects Versions: 2.18.1.Final
>            Reporter: George Gastaldi
>            Assignee: George Gastaldi
>            Priority: Minor
>             Fix For: 2.18.2.Final
>
>
> See WINDUP-601 for more details. Below is the IRC transcript about it: 
> {quote}
> <gastaldi> how about that: we remove that line and let whoever wants the output to be displayed, to call DefaultRepositorySystemSession.setTransferListener(new LogTransferListener(stream)); from the returned session?
> <mbriskar_> gastaldi, sure but if whoever wants to use MavenDependencyResolver ?
> <mbriskar_> MavenDependencyResolver will have hardcoded not using it
> <gastaldi> then no output will be displayed to System.out as it is supposed to be
> <mbriskar_> should it?
> <mbriskar_> then it's ok
> <mbriskar_> all the time I am thinking about the way how to be able to tell MavenDependencyResolver to print it
> <gastaldi> By setting the Transfer listener in that class we are assuming too much from the caller
> <mbriskar_> but OK, it sound reasonable
> <mbriskar_> s
> <gastaldi> so the best is to not set it IMHO :)
> <gastaldi> thoughts? let's vote
> <gastaldi> Who wants https://github.com/forge/furnace/blob/master/manager/resolver/maven/src/main/java/org/jboss/forge/furnace/manager/maven/MavenContainer.java#L265 to be removed?
> <mbriskar_> sure, I don't mind it because right now I don't need printouts
> <gastaldi> o/
> <mbriskar_> but I still think it may be useful to be able to tell MavenDependencyResolver to use printouts
> <gastaldi> that looks like another issue
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)