[forge-issues] [JBoss JIRA] (FORGE-2275) Refactor the JPA / Bean Validation / CDI Tests with new @AddonDependency

[Antonio Goncalves (JIRA)]

     [ https://issues.jboss.org/browse/FORGE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Goncalves updated FORGE-2275:
-------------------------------------
    Description: 
The JPA / Bean Validation / CDI Tests have recently been strenghten. It is important to refactor them with new @AddonDependency management (because these tests are used in the Tutorials and should use the latest dependency management)

Tests should look like this : https://github.com/forge/core/blob/master/maven/tests/src/test/java/org/jboss/forge/addon/maven/projects/facets/MavenFacetTest.java

There is a command to create tests : {{addon-new-test}}
https://github.com/forge/core/blob/master/addons/impl/src/main/java/org/jboss/forge/addon/addons/ui/NewFurnaceTestCommandImpl.java

So the tests go from :

{code}
   @Deployment
   @AddonDeployments({
            @AddonDeployment(name = "org.jboss.forge.addon:ui"),
            @AddonDeployment(name = "org.jboss.forge.addon:ui-test-harness"),
            @AddonDeployment(name = "org.jboss.forge.addon:shell-test-harness"),
            @AddonDeployment(name = "org.jboss.forge.addon:javaee"),
            @AddonDeployment(name = "org.jboss.forge.addon:maven")
   })
   public static AddonArchive getDeployment()
   {
      return ShrinkWrap
               .create(AddonArchive.class)
               .addClass(ProjectHelper.class)
               .addBeansXML()
               .addAsAddonDependencies(
                        AddonDependencyEntry.create("org.jboss.forge.furnace.container:cdi"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:projects"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:ui"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:ui-test-harness"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:shell-test-harness"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:javaee"),
                        AddonDependencyEntry.create("org.jboss.forge.addon:maven")
               );
   }
{code}

To 

{code}
   @Deployment
   @AddonDependencies({
            @AddonDependency(name = "org.jboss.forge.addon:ui-test-harness"),
            @AddonDependency(name = "org.jboss.forge.addon:shell-test-harness"),
            @AddonDependency(name = "org.jboss.forge.addon:javaee"),
            @AddonDependency(name = "org.jboss.forge.addon:maven"),
            @AddonDependency(name = "org.jboss.forge.furnace.container:cdi")
   })
   public static AddonArchive getDeployment()
   {
      return ShrinkWrap.create(AddonArchive.class).addBeansXML().addClass(ProjectHelper.class);
   }
{code}

But there is still a problem with the setup commands {{JPASetupWizardTest}}, {{RestSetupTest}} and {{WebSocketSetupWizardTest}}

  was:
The JPA / Bean Validation / CDI Tests have recently been strenghten. It is important to refactor them with new @AddonDependency management (because these tests are used in the Tutorials and should use the latest dependency management)

Tests should look like this : https://github.com/forge/core/blob/master/maven/tests/src/test/java/org/jboss/forge/addon/maven/projects/facets/MavenFacetTest.java

There is a command to create tests : {{addon-new-test}}
https://github.com/forge/core/blob/master/addons/impl/src/main/java/org/jboss/forge/addon/addons/ui/NewFurnaceTestCommandImpl.java



> Refactor the JPA / Bean Validation / CDI Tests with new @AddonDependency
> ------------------------------------------------------------------------
>
>                 Key: FORGE-2275
>                 URL: https://issues.jboss.org/browse/FORGE-2275
>             Project: Forge
>          Issue Type: Sub-task
>          Components: Java EE
>    Affects Versions: 2.15.1.Final
>            Reporter: Antonio Goncalves
>            Assignee: Antonio Goncalves
>             Fix For: 2.x Future
>
>
> The JPA / Bean Validation / CDI Tests have recently been strenghten. It is important to refactor them with new @AddonDependency management (because these tests are used in the Tutorials and should use the latest dependency management)
> Tests should look like this : https://github.com/forge/core/blob/master/maven/tests/src/test/java/org/jboss/forge/addon/maven/projects/facets/MavenFacetTest.java
> There is a command to create tests : {{addon-new-test}}
> https://github.com/forge/core/blob/master/addons/impl/src/main/java/org/jboss/forge/addon/addons/ui/NewFurnaceTestCommandImpl.java
> So the tests go from :
> {code}
>    @Deployment
>    @AddonDeployments({
>             @AddonDeployment(name = "org.jboss.forge.addon:ui"),
>             @AddonDeployment(name = "org.jboss.forge.addon:ui-test-harness"),
>             @AddonDeployment(name = "org.jboss.forge.addon:shell-test-harness"),
>             @AddonDeployment(name = "org.jboss.forge.addon:javaee"),
>             @AddonDeployment(name = "org.jboss.forge.addon:maven")
>    })
>    public static AddonArchive getDeployment()
>    {
>       return ShrinkWrap
>                .create(AddonArchive.class)
>                .addClass(ProjectHelper.class)
>                .addBeansXML()
>                .addAsAddonDependencies(
>                         AddonDependencyEntry.create("org.jboss.forge.furnace.container:cdi"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:projects"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:ui"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:ui-test-harness"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:shell-test-harness"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:javaee"),
>                         AddonDependencyEntry.create("org.jboss.forge.addon:maven")
>                );
>    }
> {code}
> To 
> {code}
>    @Deployment
>    @AddonDependencies({
>             @AddonDependency(name = "org.jboss.forge.addon:ui-test-harness"),
>             @AddonDependency(name = "org.jboss.forge.addon:shell-test-harness"),
>             @AddonDependency(name = "org.jboss.forge.addon:javaee"),
>             @AddonDependency(name = "org.jboss.forge.addon:maven"),
>             @AddonDependency(name = "org.jboss.forge.furnace.container:cdi")
>    })
>    public static AddonArchive getDeployment()
>    {
>       return ShrinkWrap.create(AddonArchive.class).addBeansXML().addClass(ProjectHelper.class);
>    }
> {code}
> But there is still a problem with the setup commands {{JPASetupWizardTest}}, {{RestSetupTest}} and {{WebSocketSetupWizardTest}}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)