[forge-issues] [JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.

[Ondrej Zizka (JIRA)]

    [ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051987#comment-13051987 ] 

Ondrej Zizka commented on FURNACE-21:
-------------------------------------

Yes, maybe an exception. Typically it is an outcome of wrong deployment setup. But if you WARN about it and then let it fail "naturally", it would demonstrate to the user why that matters :)  Or - if the exception contains good explanation of what it could lead to, then an exception is better.

> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FURNACE-21
>                 URL: https://issues.jboss.org/browse/FURNACE-21
>             Project: Forge: Furnace
>          Issue Type: Enhancement
>          Components: Runtime, Test Harness
>            Reporter: Ondrej Zizka
>            Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)