[forge-issues] [JBoss JIRA] (FURNACE-21) Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.

[Ondrej Zizka (JIRA)]

    [ https://issues.jboss.org/browse/FURNACE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051988#comment-13051988 ] 

Ondrej Zizka edited comment on FURNACE-21 at 3/19/15 4:24 PM:
--------------------------------------------------------------

Test case: 
{code}
git clone git at github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}
The issue is the ".addPackages(true, RuleProviderFilter.class.getPackage())" line in getDeployment().


was (Author: ozizka):
Test case: 
{code}
git clone git at github.com:OndraZizka/windup.git windup-FURNACE-21
cd windup-FURNACE-21
mvn install -DskipTests
#exec/tests/src/test/java/org/jboss/windup/test/exec/TagsIncludeExcludeTest.java
cd exec/
# Then test TagsIncludeExcludeTest.java.
{code}

> Forge Tests: WARN if _DEFAULT_ addon contains duplicate classes which are in dependencies, or duplicated classes in dependencies.
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FURNACE-21
>                 URL: https://issues.jboss.org/browse/FURNACE-21
>             Project: Forge: Furnace
>          Issue Type: Enhancement
>          Components: Runtime, Test Harness
>            Reporter: Ondrej Zizka
>            Assignee: George Gastaldi
>
> If the _DEFAULT_ addon (created by ForgeArchive getDeployment()) contains classes which duplicate those in dependencies (which is very easy to achieve), then various negative side effect may occur - e.g. querying for an @Annotation, or querying a Map with classes as keys, etc etc.
> Typically solving these errors is hard work.
> Forge, resp. Furnace, should WARN about duplicated classes. Maybe optionally if that would mean scanning all addons (but I assume that is being done anyway).
> In other words:
> 1) Scan whole _DEFAULT_ addon and for each class, try loading that class by FQCN from each dependency. If found, then WARN about it.
> 2) Scan all dependency addons and warn if duplicated FQCN is found.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)