[forge-issues] [JBoss JIRA] (FURNACE-112) Separate deploy/enable/disable methods from AddonRepository/MutableAddonRepository

[George Gastaldi (JIRA)]

    [ https://issues.jboss.org/browse/FURNACE-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237830#comment-13237830 ] 

George Gastaldi commented on FURNACE-112:
-----------------------------------------

So your suggestion is to extract an interface with these methods? Feel free to submit a PR, we'll gladly review it.

> Separate deploy/enable/disable methods from AddonRepository/MutableAddonRepository
> ----------------------------------------------------------------------------------
>
>                 Key: FURNACE-112
>                 URL: https://issues.jboss.org/browse/FURNACE-112
>             Project: Forge: Furnace
>          Issue Type: Enhancement
>          Components: Addon Manager
>    Affects Versions: 2.23.4.Final
>            Reporter: Sergei Egorov
>
> Hi! 
> Looks like AddonRepository is doing two different jobs - addons repository *and* storing the state. But if one wants to store the state of deployed & enabled addons, there is no interface to implement to keep filesystem storage of artifacts, but having state somewhere else (DB, in memory data grid, just in memory, not the file system)
> I think following methods should have their own interface:
> isEnabled()
> listAll()
> listEnabled()
> listEnabledCompatibleWithVersion()
> enable()
> disable()
> it will make it possible to provide non-FS implementation of the state storage.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)