<br><br><div class="gmail_quote">On Thu, Feb 24, 2011 at 10:21 PM, Thomas Heute <span dir="ltr"><<a href="mailto:theute@redhat.com">theute@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#ffffff" text="#000000"><div class="im">
On 02/24/2011 12:20 PM, <a href="mailto:aheritier@gmail.com" target="_blank">aheritier@gmail.com</a> wrote:
<blockquote type="cite">
<div><br>
<div class="gmail_quote">On Thu, Feb 24, 2011 at 6:01 PM, Thomas
Heute <span dir="ltr"><<a href="mailto:theute@redhat.com" target="_blank">theute@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
Now that our Maven expert is back :)<br>
</blockquote>
He he :-)
<div>Effectively, I'm back and in VN this time :-D</div>
</div>
</div>
</blockquote></div>
Oh, still on vacation then ;) <br></div></blockquote><div><br></div><div>almost :-) </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div bgcolor="#ffffff" text="#000000">
<div class="im">
<blockquote type="cite">
<div>
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
I plan to do some update in our GateIn parent, the diff
below is pretty much self explanatory, but here are the
points:<br>
<br>
- Removed repositories + pluginRepositories definitions,
it's supposed to be a best practice, correct me if I'm wrong
(But will require people to have those defined in their
local installation or we add them in the root pom.xml
instead)<br>
</blockquote>
<div>+10000 : It will also increse your build time as more you
have repositories in your settings/poms, more maven will
loose time to try missing deps or snapshots updates in them</div>
<div><a href="http://www.sonatype.com/people/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/" target="_blank">http://www.sonatype.com/people/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/</a></div>
<div>In theory (sorry the wiki is down I hope it is the good
link:( ) you should follow this doc and ask gatein community
to do it to contribute :</div>
<div><a href="http://community.jboss.org/wiki/mavensettings" target="_blank">http://community.jboss.org/wiki/mavensettings</a></div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"> - Added JDK 6 as min version<br>
</blockquote>
<div><br>
</div>
<div>Instead of setting jdk.min.version you should better set
maven.compiler.source and maven.compiler.target to 1.6 if
this is what is targeted now</div>
<div>
You can see them here : <a href="http://anonsvn.jboss.org/repos/maven/poms/jboss-parent-pom/tags/jboss-parent-5/pom.xml" target="_blank">http://anonsvn.jboss.org/repos/maven/poms/jboss-parent-pom/tags/jboss-parent-5/pom.xml</a></div>
</div>
</div>
</blockquote>
<br></div>
Shouldn't we do all ?<br>
jdk.min.version for the maven checker so that it gives a nice error
message if one tries to build with JDK 5 or older and
maven.compiler.* to pass to the Java compiler ?<br>
PS: jdk.min.version was defined in GateIn root pom, I just moved it
up to the shared parent.</div></blockquote><div><br></div><div>By default in jboss-parent pom you have : <span class="Apple-style-span" style="font-family: monospace; white-space: pre-wrap; font-size: medium; "><jdk.min.version>${maven.compiler.source}</jdk.min.version></span></div>
<div><span class="Apple-style-span" style="font-family: monospace; white-space: pre-wrap; font-size: medium; ">thus it takes the value of compiler source level</span></div><meta charset="utf-8"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#ffffff" text="#000000"><div class="im"><br>
<br>
<blockquote type="cite">
<div>
<div class="gmail_quote">
<div>
</div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"> - Removed the Maven release plugin
parameters, they are only meaningful for GateIn Portal and
not for the components. Plus we added new profiles for new
packaging (AS6, AS6, Tomcat 6, Tomcat 7, Jetty). This would
be added in the root pom of GateIn Portal<br>
</blockquote>
<div><br>
</div>
<div>I agree</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"> - Removed
org.codehaus.mojo:jboss-packaging-maven-plugin declaration,
I think it's only to build SAR packages. And SAR packages
are only used for a component or 2.<br>
<br>
</blockquote>
<div><br>
</div>
<div>+1</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<br>
Arnaud, what do you think ?<br>
</blockquote>
<div><br>
</div>
<div>It's a little bit out of your scope but we should either
think to update plugins versions defined in jboss parent pom
(we could see with Paul Gier) or override these properties
in GateIn. A lot of plugins were updated to take care of
Maven 3 and to have a better behavior in // builds for
exemple.</div>
<div>You can easily find the list of latest versions of
plugins with : mvn <span style="font-family:Verdana,Helvetica,Arial,sans-serif;font-size:13px"><a href="http://mojo.codehaus.org/versions-maven-plugin/display-plugin-updates-mojo.html" style="text-decoration:none;color:rgb(51, 102, 170)" target="_blank">versions:display-plugin-updates</a></span></div>
<div><a href="http://mojo.codehaus.org/versions-maven-plugin/examples/display-plugin-updates.html" target="_blank">http://mojo.codehaus.org/versions-maven-plugin/examples/display-plugin-updates.html</a></div>
<div><br>
</div>
<div>I may do it but it won't be I think before my travel back
from VN (in 10 days)</div>
<div><br>
</div>
<div>If you have few time it is easy: You update these
versions in gatein parent-pom, you install it, you update
locally all your gatein projects to use this SNAPSHOT and
you test a full build.</div>
</div>
</div>
</blockquote>
<br></div>
Ok, i did the update in parent that gives this as a summarize:<br>
<version.antrun.plugin>1.6</version.antrun.plugin><br>
<version.clean.plugin>2.4.1</version.clean.plugin><br>
<version.checkstyle.plugin>2.6</version.checkstyle.plugin><br>
<version.compiler.plugin>2.3.2</version.compiler.plugin><br>
<version.dependency.plugin>2.2</version.dependency.plugin><br>
<version.deploy.plugin>2.5</version.deploy.plugin><br>
<version.install.plugin>2.3.1</version.install.plugin><br>
<version.jar.plugin>2.3.1</version.jar.plugin><br>
<version.surefire.plugin>2.7.2</version.surefire.plugin><br>
<version.resources.plugin>2.4.3</version.resources.plugin><br>
<version.war.plugin>2.1.1</version.war.plugin><br>
<version.ear.plugin>2.5</version.ear.plugin><br>
<version.site.plugin>2.2</version.site.plugin><br>
<version.source.plugin>2.1.2</version.source.plugin><br>
<version.javadoc.plugin>2.7</version.javadoc.plugin><br>
<version.buildnumber.plugin>1.0-beta-4</version.buildnumber.plugin><br>
<br>
<br>
Requires Maven 3, so I didn't update:<br>
[INFO] maven-site-plugin ................................. 2.2
-> 3.0-beta-3<br>
<br></div></blockquote><div><br></div><div>I think we don't use the site thus we don't care. But if you want to be clean there is a tip to be compatible with both versions</div><div>You set the default version to 2.2 like you did</div>
<div>And you had this profile :</div><div><meta charset="utf-8"><span class="Apple-style-span" style="font-family: Helvetica, Arial, sans-serif; font-size: 13px; line-height: 17px; "><pre class="code-xml" style="padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; text-align: left; overflow-x: auto; overflow-y: auto; font-family: 'Courier New', Courier, monospace; line-height: 1.3; ">
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><profile></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><id></span>maven-3<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></id></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><activation></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><file></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><span class="code-comment" style="color: rgb(128, 128, 128); background-color: inherit; "><!-- This employs that the basedir expression is only recognized by Maven 3.x (see MNG-2363) --></span></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><exists></span>${basedir}<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></exists></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></file></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></activation></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><build></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><properties></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "><span class="Apple-style-span" style="font-family: arial; font-size: small; color: rgb(0, 0, 0); line-height: normal; white-space: normal; "><version.site.plugin>2.3-beta-3</version.site.plugin></span></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></properties></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></build></span>
<span class="code-tag" style="color: rgb(0, 0, 145); background-color: inherit; "></profile></span></pre></span></div><div> </div><div>More details : <a href="https://cwiki.apache.org/MAVEN/maven-3x-and-site-plugin.html">https://cwiki.apache.org/MAVEN/maven-3x-and-site-plugin.html</a></div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div bgcolor="#ffffff" text="#000000">
In root pom we should upgrade:<br>
[INFO] org.codehaus.mojo:build-helper-maven-plugin ..............
1.4 -> 1.5<br>
[INFO] org.codehaus.mojo:exec-maven-plugin ....................
1.1.1 -> 1.2<br>
[INFO] org.jibx:maven-jibx-plugin ...........................
1.2.1 -> 1.2.2<br>
<br>
We need to specify the plugin version in: web/eXoResources/pom.xml
and examples/skins/simpleskin/pom.xml:<br>
[WARNING] The following plugins do not have their version specified:<br>
[WARNING] gr.abiss.mvn.plugins:maven-jstools-plugin
.................... 0.7<br>
<br>
In packaging/reports/pom.xml we should upgrade:<br>
[INFO]
org.jvnet.maven-antrun-extended-plugin:maven-antrun-extended-plugin
1.13 -> 1.41<br>
<br>
In testsuite/selenium-snifftests/pom.xml we should upgrade:<br>
[INFO] org.codehaus.mojo:selenium-maven-plugin ..................
1.0 -> 1.1<br>
<br></div></blockquote><div><br></div><div>If they all extends the gatein-parent you can define this versions directly in it instead of hardcoding it in child projects.</div><div>Like in jboss-parent just declare all missing plugins in build/pluginsManagement/plugins with a property for each version.</div>
<div><br></div><div>Cheers</div><div><br></div><div>Arnaud</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div bgcolor="#ffffff" text="#000000">
Thanks !<br><font color="#888888">
Thomas.</font><div><div></div><div class="h5"><br>
<br>
<blockquote type="cite">
<div>
<div class="gmail_quote">
<div><br>
</div>
<div>cheers</div>
<div><br>
</div>
<div>arnaud</div>
<div><br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<br>
Thomas.<br>
<br>
<br>
<br>
<br>
Here is the diff:
<div><br>
Index: pom.xml<br>
===================================================================<br>
--- pom.xml (revision 5914)<br>
+++ pom.xml (working copy)<br>
@@ -14,7 +14,7 @@<br>
<br>
<groupId>org.gatein</groupId><br>
<artifactId>gatein-parent</artifactId><br>
- <version>1.0.3-GA-SNAPSHOT</version><br>
+ <version>1.1.0-GA-SNAPSHOT</version><br>
<packaging>pom</packaging><br>
<br>
<scm><br>
</div>
@@ -40,12 +40,11 @@
<div><br>
<!-- maven-enforcer-plugin --><br>
<maven.min.version>2.2.1</maven.min.version><br>
<br>
+ <jdk.min.version>1.6</jdk.min.version><br>
+<br>
<!-- maven-release-plugin --><br>
<autoVersionSubmodules>true</autoVersionSubmodules><br>
<br>
- <!-- maven-release-plugin --><br>
- <arguments>-Prelease,pkg-tomcat,pkg-jbossas
-DskipTests</arguments><br>
</div>
<div>
-<br>
<!-- cf <a href="http://jira.codehaus.org/browse/MRELEASE-3" target="_blank">http://jira.codehaus.org/browse/MRELEASE-3</a>
--><br>
<preparationGoals>clean
install</preparationGoals><br>
</div>
</properties><br>
@@ -60,11 +59,6 @@
<div><br>
<!-- Plugins are sorted by shortname : clean, deploy,
... --><br>
<plugins><br>
<plugin><br>
- <groupId>org.codehaus.mojo</groupId><br>
-
<artifactId>jboss-packaging-maven-plugin</artifactId><br>
- <version>2.0-beta-1</version><br>
- </plugin><br>
- <plugin><br>
<groupId>org.apache.maven.plugins</groupId><br>
<artifactId>maven-jar-plugin</artifactId><br>
<configuration><br>
</div>
@@ -167,43 +161,6 @@
<div>
<div><br>
</profiles><br>
<br>
<!-- **************** --><br>
- <!-- Repositiories --><br>
- <!-- **************** --><br>
- <repositories><br>
- <repository><br>
- <id>jboss-public-repository-group</id><br>
- <name>JBoss Public Maven Repository
Group</name><br>
- <url><a href="https://repository.jboss.org/nexus/content/groups/public/" target="_blank">https://repository.jboss.org/nexus/content/groups/public/</a></url><br>
- <layout>default</layout><br>
- <releases><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </releases><br>
- <snapshots><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </snapshots><br>
- </repository><br>
- </repositories><br>
-<br>
- <pluginRepositories><br>
- <pluginRepository><br>
- <id>jboss-public-repository-group</id><br>
- <name>JBoss Public Maven Repository
Group</name><br>
- <url><a href="https://repository.jboss.org/nexus/content/groups/public/" target="_blank">https://repository.jboss.org/nexus/content/groups/public/</a></url><br>
- <layout>default</layout><br>
- <releases><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </releases><br>
- <snapshots><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </snapshots><br>
- </pluginRepository><br>
- </pluginRepositories><br>
-<br>
- <!-- **************** --><br>
<!-- Reporting --><br>
<!-- **************** --><br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br>