<div><br><div class="gmail_quote">On Thu, Feb 24, 2011 at 6:01 PM, Thomas Heute <span dir="ltr"><<a href="mailto:theute@redhat.com">theute@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Now that our Maven expert is back :)<br></blockquote><meta charset="utf-8">He he :-)<div>Effectively, I'm back and in VN this time :-D</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I plan to do some update in our GateIn parent, the diff below is pretty much self explanatory, but here are the points:<br>
<br>
- Removed repositories + pluginRepositories definitions, it's supposed to be a best practice, correct me if I'm wrong (But will require people to have those defined in their local installation or we add them in the root pom.xml instead)<br>
</blockquote><div>+10000 : It will also increse your build time as more you have repositories in your settings/poms, more maven will loose time to try missing deps or snapshots updates in them</div><div><a href="http://www.sonatype.com/people/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/">http://www.sonatype.com/people/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/</a></div>
<div>In theory (sorry the wiki is down I hope it is the good link:( ) you should follow this doc and ask gatein community to do it to contribute :</div><div><a href="http://community.jboss.org/wiki/mavensettings">http://community.jboss.org/wiki/mavensettings</a></div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- Added JDK 6 as min version<br></blockquote><div><br></div><div>Instead of setting jdk.min.version you should better set maven.compiler.source and maven.compiler.target to 1.6 if this is what is targeted now</div><div>
You can see them here : <a href="http://anonsvn.jboss.org/repos/maven/poms/jboss-parent-pom/tags/jboss-parent-5/pom.xml">http://anonsvn.jboss.org/repos/maven/poms/jboss-parent-pom/tags/jboss-parent-5/pom.xml</a></div><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- Removed the Maven release plugin parameters, they are only meaningful for GateIn Portal and not for the components. Plus we added new profiles for new packaging (AS6, AS6, Tomcat 6, Tomcat 7, Jetty). This would be added in the root pom of GateIn Portal<br>
</blockquote><div><br></div><div>I agree</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- Removed org.codehaus.mojo:jboss-packaging-maven-plugin declaration, I think it's only to build SAR packages. And SAR packages are only used for a component or 2.<br>
<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Arnaud, what do you think ?<br></blockquote><div><br></div><div>It's a little bit out of your scope but we should either think to update plugins versions defined in jboss parent pom (we could see with Paul Gier) or override these properties in GateIn. A lot of plugins were updated to take care of Maven 3 and to have a better behavior in // builds for exemple.</div>
<div>You can easily find the list of latest versions of plugins with : mvn <span class="Apple-style-span" style="font-family: Verdana, Helvetica, Arial, sans-serif; font-size: 13px; "><a href="http://mojo.codehaus.org/versions-maven-plugin/display-plugin-updates-mojo.html" style="text-decoration: none; color: rgb(51, 102, 170); ">versions:display-plugin-updates</a></span></div>
<div><a href="http://mojo.codehaus.org/versions-maven-plugin/examples/display-plugin-updates.html">http://mojo.codehaus.org/versions-maven-plugin/examples/display-plugin-updates.html</a></div><div><br></div><div>I may do it but it won't be I think before my travel back from VN (in 10 days)</div>
<div><br></div><div>If you have few time it is easy: You update these versions in gatein parent-pom, you install it, you update locally all your gatein projects to use this SNAPSHOT and you test a full build.</div><div><br>
</div><meta charset="utf-8"><div>cheers</div><div><br></div><div>arnaud</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Thomas.<br>
<br>
<br>
<br>
<br>
Here is the diff:<div class="im"><br>
Index: pom.xml<br>
===================================================================<br>
--- pom.xml (revision 5914)<br>
+++ pom.xml (working copy)<br>
@@ -14,7 +14,7 @@<br>
<br>
<groupId>org.gatein</groupId><br>
<artifactId>gatein-parent</artifactId><br>
- <version>1.0.3-GA-SNAPSHOT</version><br>
+ <version>1.1.0-GA-SNAPSHOT</version><br>
<packaging>pom</packaging><br>
<br>
<scm><br></div>
@@ -40,12 +40,11 @@<div class="im"><br>
<!-- maven-enforcer-plugin --><br>
<maven.min.version>2.2.1</maven.min.version><br>
<br>
+ <jdk.min.version>1.6</jdk.min.version><br>
+<br>
<!-- maven-release-plugin --><br>
<autoVersionSubmodules>true</autoVersionSubmodules><br>
<br>
- <!-- maven-release-plugin --><br>
- <arguments>-Prelease,pkg-tomcat,pkg-jbossas -DskipTests</arguments><br></div><div class="im">
-<br>
<!-- cf <a href="http://jira.codehaus.org/browse/MRELEASE-3" target="_blank">http://jira.codehaus.org/browse/MRELEASE-3</a> --><br>
<preparationGoals>clean install</preparationGoals><br></div>
</properties><br>
@@ -60,11 +59,6 @@<div class="im"><br>
<!-- Plugins are sorted by shortname : clean, deploy, ... --><br>
<plugins><br>
<plugin><br>
- <groupId>org.codehaus.mojo</groupId><br>
- <artifactId>jboss-packaging-maven-plugin</artifactId><br>
- <version>2.0-beta-1</version><br>
- </plugin><br>
- <plugin><br>
<groupId>org.apache.maven.plugins</groupId><br>
<artifactId>maven-jar-plugin</artifactId><br>
<configuration><br></div>
@@ -167,43 +161,6 @@<div><div></div><div class="h5"><br>
</profiles><br>
<br>
<!-- **************** --><br>
- <!-- Repositiories --><br>
- <!-- **************** --><br>
- <repositories><br>
- <repository><br>
- <id>jboss-public-repository-group</id><br>
- <name>JBoss Public Maven Repository Group</name><br>
- <url><a href="https://repository.jboss.org/nexus/content/groups/public/" target="_blank">https://repository.jboss.org/nexus/content/groups/public/</a></url><br>
- <layout>default</layout><br>
- <releases><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </releases><br>
- <snapshots><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </snapshots><br>
- </repository><br>
- </repositories><br>
-<br>
- <pluginRepositories><br>
- <pluginRepository><br>
- <id>jboss-public-repository-group</id><br>
- <name>JBoss Public Maven Repository Group</name><br>
- <url><a href="https://repository.jboss.org/nexus/content/groups/public/" target="_blank">https://repository.jboss.org/nexus/content/groups/public/</a></url><br>
- <layout>default</layout><br>
- <releases><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </releases><br>
- <snapshots><br>
- <enabled>true</enabled><br>
- <updatePolicy>never</updatePolicy><br>
- </snapshots><br>
- </pluginRepository><br>
- </pluginRepositories><br>
-<br>
- <!-- **************** --><br>
<!-- Reporting --><br>
<!-- **************** --><br>
<br>
</div></div></blockquote></div><br></div>