I think there is more to study because we are using currently google collections and google guava redefines a set of classes from google collections (com.google.common.base, com.google.common.collect, com.google.common.annotations). Some of those packages contains new classes in Google Guava.<div>
<br></div><div>It implies that we should get rid of google collections and replace it by guava at runtime. It means that dependencies relying on google collection (like shindig) should be tested to ensure that the usage of Guava works fine before.</div>
<div><br></div><div>It also implies that google guava should be compatible with google collection, I'm sure it is, but I cannot assess it.</div><div><br></div><div>Perhaps we have also other dependencies that are using google collections but I'm not aware of them (I haven't searched though).<br>
<br></div><div>Could you give a try first at replacing the collection dependency by the guava dependency and see if it's ok ?</div><div><br><div class="gmail_quote">On Thu, Mar 24, 2011 at 10:23 AM, Thomas Heute <span dir="ltr"><<a href="mailto:theute@redhat.com">theute@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#ffffff" text="#000000"><div class="im">
On 03/24/2011 10:07 AM, Julien Viet wrote:
<blockquote type="cite">there is one compressor implementation from Google
that is done, but I wanted to check before that adding a
dependency to Google Guava won't hurt in trunk.
<div><br>
</div>
<div>if it's ok for you, this can be commited I think.</div>
<div><br>
</div>
<div>I don't know if the compressor is better though.</div>
</blockquote>
<br></div>
We should give it a try, Dojo doesn't seem to be working at the
moment because of that issue.<div class="im"><br>
<br>
<br>
<br>
<blockquote type="cite">
<div><br>
<div class="gmail_quote">On Thu, Mar 24, 2011 at 10:04 AM,
Thomas Heute <span dir="ltr"><<a href="mailto:theute@redhat.com" target="_blank">theute@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><br>
Javascript merge/compressing seems to not behave well in all
cases and<br>
we got a couple of comments from customers and users:<br>
<br>
<a href="https://issues.jboss.org/browse/GTNPORTAL-1182" target="_blank">https://issues.jboss.org/browse/GTNPORTAL-1182</a><br>
<br>
What's the status on this ? I remember that we looked into
other JS<br>
compressors but what was the decision on this ?<br>
<br>
<br>
Thomas<br>
_______________________________________________<br>
gatein-dev mailing list<br>
<a href="mailto:gatein-dev@lists.jboss.org" target="_blank">gatein-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/gatein-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/gatein-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div>
</blockquote></div><br></div>