[gatein-issues] [JBoss JIRA] Commented: (GTNPORTAL-1720) Rename the confusing methods setFullRender/getFullRender in PortalRequestHandler

Trong Tran (JIRA) jira-events at lists.jboss.org
Thu Dec 16 05:48:18 EST 2010


    [ https://issues.jboss.org/browse/GTNPORTAL-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570647#comment-12570647 ] 

Trong Tran commented on GTNPORTAL-1720:
---------------------------------------

We should still keep the old one and just annotate it as @deprecated for compatibility with previous versions

> Rename the confusing methods setFullRender/getFullRender  in PortalRequestHandler
> ---------------------------------------------------------------------------------
>
>                 Key: GTNPORTAL-1720
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-1720
>             Project: GateIn Portal
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>            Reporter: Minh Hoang TO
>              Labels: portal-s45
>
> {code:java}
> /**
>     * Sets a boolean value to force whether portal will be fully rendered
>     * and it is only effective to an Ajax request.<p/>
>     * 
>     * if the value is set to <code>true</code>, it means :<br/>
>     *
>     * 1) Only portal ui components are rendered <br/>
>     * 2) Portlets will be fully rendered if are inner of the portal ui components being updated
>     * 
>     * @param forceFullUpdate
>     */
>    final public void setFullRender(boolean forceFullUpdate)
>    {
>       this.forceFullUpdate = forceFullUpdate;
>    }
> {code}
>   As mentioned in the Javadoc, while AJAX update is used, the forceFullUpdate decides whether only components of portal (ie: The components outside portlet window UIPortlet such as UIMaskWorkspace, UIWorkingWorkspace,...) are updated by AJAX
>  The name of method is very confusing. If we wish to update only components of portal, we have to call setFullRender(true)  (I'm sure that most developers think of setFullRender(false) )

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the gatein-issues mailing list