[gatein-issues] [JBoss JIRA] Commented: (GTNWSRP-92) Need to handle properly values that are now mandatory while they were optional in v1

[Matt Wringe (JIRA)]

    [ https://jira.jboss.org/browse/GTNWSRP-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555709#action_12555709 ] 

Matt Wringe commented on GTNWSRP-92:
------------------------------------

Other than the issues listed above with the RuntimeContext:

- NamedString: Value is required in V1, optional in V2. The conversion of V1 to V2 is ok, from V2 to V1 should be fine as it should be getting values original passed through from V1. Just in case, will set the value to be equal to the name (which is required) if converting from V2 to V1 and the value is null.

- SessionContext: sessionID is required in V1, optional in V2. Going from V1 to V2 is ok. Going from V2 to V1 might be a slight problem, since a sessioncontext is not required (it can be null) we should probably set it to null if the sessionID is not set.
>From the 2.0 spec "If the Consumer fails to return this reference on future invocations, the Portlet will be unable to reference this state and therefore likely not generate a markup fragment meeting the End-User's expectations". Not sure why this is an optional value for V2. 

- ItemDescription: description is required in V1, optional in V2. From V1 to V2 should be fine. From V2 to V1, if the description is null, then use the displayName instead. If for some reason both of those values are null, display a message that the description is missing (since the primary reason for the description is to display a message to the user).

- DestroyFailed (V1) or PortletDestroyed (V2 equivalent): reason is required in V1, but optional in V2. This should not cause a problem, as we use the V2 ErrorCode (which is required) to construct the V1 reason (which means for V1 the reason will always be set).


- CustomUserPorfilesData/CustomUserProfileDescription only appears in V1, but its an option feature and we don't use it anyways.
- 'Any' type has processContext='lax' added in the V2 xsd. This shouldn't cause any problems.

> Need to handle properly values that are now mandatory while they were optional in v1
> ------------------------------------------------------------------------------------
>
>                 Key: GTNWSRP-92
>                 URL: https://jira.jboss.org/browse/GTNWSRP-92
>             Project: GateIn WSRP
>          Issue Type: Task
>          Components: Specification Support
>    Affects Versions: 2.0.0-Alpha03
>            Reporter: Chris Laprun
>            Assignee: Matt Wringe
>             Fix For: 2.0.0-Beta
>
>
> For example, RuntimeContext has mandatory namespacePrefix and portletInstanceKey in v2, whereas these values were optional in v1.
> Conversion methods need to be adapted so that we can provide appropriate values for potentially missing fields.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira