[gatein-issues] [JBoss JIRA] Created: (GTNPORTAL-1516) Check null to catch exception of WebuiBindingContext.appRes

[kien nguyen (JIRA)]

Check null to catch exception of WebuiBindingContext.appRes
-----------------------------------------------------------

                 Key: GTNPORTAL-1516
                 URL: https://jira.jboss.org/browse/GTNPORTAL-1516
             Project: GateIn Portal
          Issue Type: Bug
      Security Level: Public (Everyone can see)
    Affects Versions: 3.1.0-GA
            Reporter: kien nguyen
            Priority: Minor


Sometimes, we can get an exception as:

WARNING: Can not find resource bundle for key : null
Oct 1, 2010 10:42:01 AM org.exoplatform.portal.application.PortalRequestHandler execute
SEVERE: Error while handling request
org.exoplatform.groovyscript.TemplateRuntimeException: Groovy template exception at DataText[pos=Position[col=1,line=64],data=					msgValue = msgValue.replace("{" + i + "}", _ctx.appRes(msgArguments [i]));] for template system:/groovy/webui/core/UIPopupMessages.gtmpl
	at org.exoplatform.groovyscript.GroovyScript.buildRuntimeException(GroovyScript.java:178)
	at org.exoplatform.groovyscript.GroovyScript.render(GroovyScript.java:121)
	at org.exoplatform.groovyscript.GroovyTemplate.render(GroovyTemplate.java:118)
	at org.exoplatform.groovyscript.text.TemplateService.merge(TemplateService.java:117)
	at org.exoplatform.webui.core.lifecycle.Lifecycle.renderTemplate(Lifecycle.java:128)
	at org.exoplatform.webui.core.lifecycle.Lifecycle.processRender(Lifecycle.java:85)
	at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
	at org.exoplatform.webui.core.UIPopupMessages.processRender(UIPopupMessages.java:102)
	at org.exoplatform.webui.core.UIApplication.renderBlockToUpdate(UIApplication.java:141)
	at org.exoplatform.portal.webui.workspace.UIPortalApplication.processRender(UIPortalApplication.java:571)
	at org.exoplatform.portal.application.PortalRequestHandler.execute(PortalRequestHandler.java:117)
	at org.exoplatform.web.WebAppController.service(WebAppController.java:139)
	at org.exoplatform.portal.application.PortalController.onService(PortalController.java:127)
	at org.exoplatform.container.web.AbstractHttpServlet.service(AbstractHttpServlet.java:116)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.web.filter.ExtensibleFilter$ExtensibleFilterChain.doFilter(ExtensibleFilter.java:112)
	at org.exoplatform.web.filter.ExtensibleFilter.doFilter(ExtensibleFilter.java:84)
	at org.exoplatform.web.filter.GenericFilter.doFilter(GenericFilter.java:66)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.web.CacheUserProfileFilter.doFilter(CacheUserProfileFilter.java:72)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.frameworks.jcr.web.ThreadLocalSessionProviderInitializedFilter.doFilter(ThreadLocalSessionProviderInitializedFilter.java:116)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.services.security.web.SetCurrentIdentityFilter.doFilter(SetCurrentIdentityFilter.java:76)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.portal.application.localization.LocalizationFilter.doFilter(LocalizationFilter.java:161)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.exoplatform.web.login.ClusteredSSOFilter.doFilter(ClusteredSSOFilter.java:73)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.NullPointerException
	at org.exoplatform.webui.core.lifecycle.WebuiBindingContext.appRes(WebuiBindingContext.java:102)
	at sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:229)
	at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:52)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
	at UIPopupMessages.printMessages(UIPopupMessages.gtmpl:64)
	at UIPopupMessages$printMessages.callCurrent(Unknown Source)
	at UIPopupMessages.run(UIPopupMessages.gtmpl:122)
	at org.exoplatform.groovyscript.GroovyScript.render(GroovyScript.java:111)
	... 46 more


The reason, at the line: value = mesgKey.substring(mesgKey.lastIndexOf('.') + 1); of appRes(String mesgKey) method, we don't check or catch if mesgKey is null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira