[gatein-issues] [JBoss JIRA] (GTNPORTAL-2299) Test Transaction's status before commit

[Hai Nguyen (Assigned) (JIRA)]

     [ https://issues.jboss.org/browse/GTNPORTAL-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hai Nguyen reassigned GTNPORTAL-2299:
-------------------------------------

    Assignee: Hai Nguyen

    
> Test Transaction's status before commit
> ---------------------------------------
>
>                 Key: GTNPORTAL-2299
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-2299
>             Project: GateIn Portal
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>            Reporter: kien nguyen
>            Assignee: Hai Nguyen
>              Labels: portal-s65
>             Fix For: 3.2.0-CR01
>
>
> In PicketLinkIDMOrganizationServiceImpl.endRequest, the transaction.commit is called without testing if the Transaction is active or not.
> But in PicketLinkIDMOrganizationServiceImpl.startRequest, you tests on transaction's status.
> So you have to do the same in endRequest:
> {code}
> if (configuration.isUseJTA()) {
>   UserTransaction tx = (UserTransaction)new InitialContext().lookup("java:comp/UserTransaction");
>   tx.commit();
> } else {
>   idmService_.getIdentitySession().getTransaction().commit();
> }{code}
> should become something like this:
> {code}
> if (configuration.isUseJTA()) {
>   UserTransaction tx = (UserTransaction)new InitialContext().lookup("java:comp/UserTransaction");
>   if (tx.getStatus() == Status.STATUS_ACTIVE) {
>     tx.commit();
>   }
> } else {
>   if (idmService_.getIdentitySession().getTransaction().isActive()){
>     idmService_.getIdentitySession().getTransaction().commit();
>   }
> }{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira