[gatein-issues] [JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode

Nick Scavelli (JIRA) jira-events at lists.jboss.org
Mon Dec 3 17:20:21 EST 2012


    [ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739080#comment-12739080 ] 

Nick Scavelli commented on GTNPORTAL-2751:
------------------------------------------

I think this might be a bug with the NavigationImporter because it looks like priority is ignored for overwrite as well. It also should be noted that priority only seems to matter for the group navigation, as changing the priority on classic and mobile seemed to do nothing. Some clarification from someone with expertise in this area would be helpful.
                
> <priority> in navigation.xml files ignored for merge importMode 
> ----------------------------------------------------------------
>
>                 Key: GTNPORTAL-2751
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-2751
>             Project: GateIn Portal
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>            Reporter: Peter Palaga
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}. 
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and  {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and  {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Configuration]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the gatein-issues mailing list