[gatein-issues] [JBoss JIRA] (GTNPORTAL-2685) Avoid calling of RequestLifeCycle methods in RedirectRequestHandler and delegate to WebAppController instead

[Matt Wringe (JIRA)]

    [ https://issues.jboss.org/browse/GTNPORTAL-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733496#comment-12733496 ] 

Matt Wringe commented on GTNPORTAL-2685:
----------------------------------------

PR sent
                
> Avoid calling of RequestLifeCycle methods in RedirectRequestHandler and delegate to WebAppController instead
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: GTNPORTAL-2685
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-2685
>             Project: GateIn Portal
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: Mobile, Performance
>    Affects Versions: 3.4.0.Final
>            Reporter: Marek Posolda
>            Assignee: Matt Wringe
>             Fix For: 3.5.0.Final
>
>
> Currently method RedirectRequestHandler.execute() wrapps it's content in RequestLifeCycle calls:
> {code}
>    @Override
>    public boolean execute(ControllerContext context) throws Exception
>    {
>       RequestLifeCycle.begin(ExoContainerContext.getCurrentContainer());
>       
>       ...
>             finally
>       {
>          RequestLifeCycle.end();
>       }
>    }
> {code}
> It seems to me that it's not needed. These calls to RequestLifeCycle.begin/RequestLifeCycle.end can be skipped and instead method "getRequiresLifecycle" should be changed to return true (It returns false currently)
> In this case, WebAppController will take care of properly starting RequestLifeCycle, so it won't be needed anymore to be started/finished directly in RedirectRequestHandler.execute(). 
> This has one important advantage, that RequestLifeCycle from WebAppController can be reused by both RedirectRequestHandler and PortalRequestHandler, so we will have only one RequestLifeCycle call during whole HTTP request (currently we have 2 RequestLifeCycles, which is not good from performance perspective).
> See method WebAppController.service for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira