[gatein-issues] [JBoss JIRA] (GTNPORTAL-2712) Issues with AbstractTokenService garbage collection of tokens

[Boleslaw Dawidowicz (JIRA)]

     [ https://issues.jboss.org/browse/GTNPORTAL-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boleslaw Dawidowicz updated GTNPORTAL-2712:
-------------------------------------------

           Status: Resolved  (was: Pull Request Sent)
    Fix Version/s: 3.5.0.Final
                       (was: 3.6.0.Final)
       Resolution: Done

    
> Issues with AbstractTokenService garbage collection of tokens
> -------------------------------------------------------------
>
>                 Key: GTNPORTAL-2712
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-2712
>             Project: GateIn Portal
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>            Reporter: Stian Thorgersen
>            Assignee: Stian Thorgersen
>             Fix For: 3.5.0.Final
>
>
> There's a few simple improvements that can be made to the garbage collection of expired tokens in AbstractTokenService.
> If an exception is thrown in cleanExpiredTokens this will cause the executor to stop running garbage collection until the server is restarted. There's is also no warning/error in the log for this.
> A NPE can be thrown in cleanExpiredTokens if a token is deleted between getAllTokens and getToken as the if statement that checks if a token is expired doesn't test for null.
> There are several implementations of AbstractTokenService which all have their own scheduled executor service.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira