[gatein-issues] [JBoss JIRA] (GTNPORTAL-3257) REST MOP Import doesn't detect errors on commit

[Nick Scavelli (JIRA)]

     [ https://issues.jboss.org/browse/GTNPORTAL-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Scavelli updated GTNPORTAL-3257:
-------------------------------------

              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/gatein/gatein-portal/pull/717

    
> REST MOP Import doesn't detect errors on commit
> -----------------------------------------------
>
>                 Key: GTNPORTAL-3257
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-3257
>             Project: GateIn Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: REST API
>    Affects Versions: 3.6.0.Final
>            Reporter: Toshiya Kobayashi
>            Assignee: Nick Scavelli
>
> When you call REST MOP Import:
> {noformat}
> curl -v -u root:gtn -X PUT -H 'Content-type: application/zip' --upload-file portal_classic_2013-06-10_15-16-53.zip http://localhost:8080/rest/private/managed-components/mop?importMode=overwrite
> {noformat}
> It returns 200 OK even if it fails on JCR commit (for example, cache replication timeout).
> Because JCR commit happens in RequestLifeCycle.end() after requestHandler.handleRequest() which flushes http response.
> https://github.com/exoplatform/ws/blob/master/exo.ws.rest.core/src/main/java/org/exoplatform/services/rest/servlet/RestServlet.java
> {code:java}
>    protected void onService(ExoContainer container, HttpServletRequest httpRequest, HttpServletResponse httpResponse)
>       throws IOException, ServletException
>    {
> ...
>       try
>       {
>          EnvironmentContext.setCurrent(env);
>          ServletContainerRequest request = new ServletContainerRequest(httpRequest);
>          ContainerResponse response = new ContainerResponse(new ServletContainerResponseWriter(httpResponse));
>          requestHandler.handleRequest(request, response);
>       }
> ...
>       finally
>       {
>          EnvironmentContext.setCurrent(null);
>          RequestLifeCycle.end();
>       }
>    }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira