[gatein-issues] [JBoss JIRA] (GTNPORTAL-3322) Improvements of handling of <priority> in navigation.xml

[Peter Palaga (JIRA)]

     [ https://issues.jboss.org/browse/GTNPORTAL-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Palaga updated GTNPORTAL-3322:
------------------------------------

    Description: 
This is followup of GTNPORTAL-2751, GTNPORTAL-3324 and GTNPORTAL-3350.

(1) Introduce {{PageNavigation.UNDEFINED_PRIORITY}} constant and use it instead of {{-1}} literal as {{PageNavigation.priority}} value. 

(2) {{UNDEFINED_PRIORITY}} and its usage should be described in comments.

(3) Fix the comparator in [UserPortalImpl|https://github.com/gatein/gatein-portal/blob/master/component/portal/src/main/java/org/exoplatform/portal/mop/user/UserPortalImpl.java#L149] as it does not impose a total ordering as required by the Comparator interface: "The implementor must ensure that sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y." This does not hold when comparing two nodes both having priority -1.

  was:
This is followup of GTNPORTAL-2751, GTNPORTAL-3297 and GTNPORTAL-3350.

(1) Introduce {{PageNavigation.UNDEFINED_PRIORITY}} constant and use it instead of {{-1}} literal as {{PageNavigation.priority}} value. 

(2) {{UNDEFINED_PRIORITY}} and its usage should be described in comments.

(3) Fix the comparator in [UserPortalImpl|https://github.com/gatein/gatein-portal/blob/master/component/portal/src/main/java/org/exoplatform/portal/mop/user/UserPortalImpl.java#L149] as it does not impose a total ordering as required by the Comparator interface: "The implementor must ensure that sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y." This does not hold when comparing two nodes both having priority -1.


    
> Improvements of handling of <priority> in navigation.xml
> --------------------------------------------------------
>
>                 Key: GTNPORTAL-3322
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-3322
>             Project: GateIn Portal
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>            Reporter: Peter Palaga
>            Assignee: Peter Palaga
>             Fix For: 3.7.0.Final
>
>
> This is followup of GTNPORTAL-2751, GTNPORTAL-3324 and GTNPORTAL-3350.
> (1) Introduce {{PageNavigation.UNDEFINED_PRIORITY}} constant and use it instead of {{-1}} literal as {{PageNavigation.priority}} value. 
> (2) {{UNDEFINED_PRIORITY}} and its usage should be described in comments.
> (3) Fix the comparator in [UserPortalImpl|https://github.com/gatein/gatein-portal/blob/master/component/portal/src/main/java/org/exoplatform/portal/mop/user/UserPortalImpl.java#L149] as it does not impose a total ordering as required by the Comparator interface: "The implementor must ensure that sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y." This does not hold when comparing two nodes both having priority -1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira