[gatein-issues] [JBoss JIRA] (GTNPORTAL-3110) IDM DAO classes are only catching IdentityExceptions

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/GTNPORTAL-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787656#comment-12787656 ] 

RH Bugzilla Integration commented on GTNPORTAL-3110:
----------------------------------------------------

Honza Fnukal <hfnukal at redhat.com> changed the Status of [bug 973039|https://bugzilla.redhat.com/show_bug.cgi?id=973039] from MODIFIED to ON_QA
                
> IDM DAO classes are only catching IdentityExceptions
> ----------------------------------------------------
>
>                 Key: GTNPORTAL-3110
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-3110
>             Project: GateIn Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Identity integration
>    Affects Versions: 3.6.0.Beta02
>            Reporter: Martin Weiler
>            Assignee: Marek Posolda
>             Fix For: 3.6.0.Final
>
>
> In some IDM DAO classes, such as GroupDAOImpl, MembershipDAOImpl and UserProfileDAOImpl all IDM calls are wrapped with try..catch(Exception e) blocks, which ensures that not only IdentityException, but also Hibernate exceptions are caught and recovered with rollback().
> But in UserDAOImpl only "IdentityException e" instances are caught. So HibernateException are not handled, which can result in transaction errors. Additionally, in MembershipTypeDAOImpl the IDM calls are not wrapped with any catch blocks, which also needs to be fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira