[gatein-issues] [JBoss JIRA] (GTNPORTAL-3436) Should not encode ampersand (&) in src attribute of html script tag

[Lucas Ponce (JIRA)]

    [ https://issues.jboss.org/browse/GTNPORTAL-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12957974#comment-12957974 ] 

Lucas Ponce commented on GTNPORTAL-3436:
----------------------------------------

I've performed several non regression tests with dashboard and gadgets and I didn't see this one.

This issue can be reproduce with out-of-the-box gadgets in gatein or there are additional tests to reproduce it ?

That can help to validate it.

Thanks again.
Lucas
                
> Should not encode ampersand (&) in src attribute of html script tag
> -------------------------------------------------------------------
>
>                 Key: GTNPORTAL-3436
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-3436
>             Project: GateIn Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Vu Viet Phuong
>            Assignee: Lucas Ponce
>            Priority: Minor
>
> The bug was introduce by this commit https://github.com/gatein/gatein-portal/commit/b5b8eedf86733235f40d2161a73e75693c8facf3#diff-13
> {code}
> String amp = "&"
> gadgets.pubsubURL = hostName + '/js/gatein-container.js?c=1' + (debug ? amp + "debug=1": "") + (nocache ? amp +"nocache=1" : amp + "nocache=0");
> {code}
> pubsubURL will be loaded by js loader (requirejs) that build a script tag an put it in the html header. 
> --> Script loading this way will not decode the "&" to "&" then server will receive "amp;debug" instead of "debug" parameter --> wrong parameter name on server

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira