From issues at jboss.org Mon Dec 1 04:14:40 2014 From: issues at jboss.org (Lucas Ponce (JIRA)) Date: Mon, 1 Dec 2014 04:14:40 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3567) Soak test throws eviction warnings In-Reply-To: References: Message-ID: Lucas Ponce created GTNPORTAL-3567: -------------------------------------- Summary: Soak test throws eviction warnings Key: GTNPORTAL-3567 URL: https://issues.jboss.org/browse/GTNPORTAL-3567 Project: GateIn Portal Issue Type: Bug Affects Versions: 3.8.9.Alpha02 Environment: Soak test of 8h sending traffic to a benchmark example portal. Reporter: Lucas Ponce Assignee: Lucas Ponce Fix For: 3.8.9.Alpha03 After 2h of test, log shows warning similar as: {code} [JBossINF] 01:24:16,783 INFO [org.jboss.as] (Controller Boot Thread) JBAS015874: JBoss Portal 6.2.0.DR3-prod-jcr-1.15.x (AS 7.4.0.Final-redhat-19) started in 94131ms - Started 1742 of 1777 services (139 services are lazy, passive or on-demand) [JBossINF] 03:39:49,039 WARN [org.jboss.cache.RegionImpl] (http-perf11/10.16.88.189:8080-288) putNodeEvent(): eviction node event queue size is at 98% threshold value of capacity: 1000000 Region: /repository_portal-system You will need to reduce the wakeUpIntervalSeconds parameter. {code} -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Mon Dec 1 08:38:39 2014 From: issues at jboss.org (Lucas Ponce (JIRA)) Date: Mon, 1 Dec 2014 08:38:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3567) Soak test throws eviction warnings In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024132#comment-13024132 ] Lucas Ponce commented on GTNPORTAL-3567: ---------------------------------------- A 4 hours Soak test ran locally over default pages couldn't reproduce reported issue. I'm going to check differences between lab env and local. > Soak test throws eviction warnings > ---------------------------------- > > Key: GTNPORTAL-3567 > URL: https://issues.jboss.org/browse/GTNPORTAL-3567 > Project: GateIn Portal > Issue Type: Bug > Affects Versions: 3.8.9.Alpha02 > Environment: Soak test of 8h sending traffic to a benchmark example portal. > Reporter: Lucas Ponce > Assignee: Lucas Ponce > Fix For: 3.8.9.Alpha03 > > > After 2h of test, log shows warning similar as: > {code} > [JBossINF] 01:24:16,783 INFO [org.jboss.as] (Controller Boot Thread) JBAS015874: JBoss Portal 6.2.0.DR3-prod-jcr-1.15.x (AS 7.4.0.Final-redhat-19) started in 94131ms - Started 1742 of 1777 services (139 services are lazy, passive or on-demand) > [JBossINF] 03:39:49,039 WARN [org.jboss.cache.RegionImpl] (http-perf11/10.16.88.189:8080-288) putNodeEvent(): eviction node event queue size is at 98% threshold value of capacity: 1000000 Region: /repository_portal-system You will need to reduce the wakeUpIntervalSeconds parameter. > {code} -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 03:42:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 03:42:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3569) Reduce the performance impact of the cache of the TemplateService in a cluster In-Reply-To: References: Message-ID: Nicolas Filotto created GTNPORTAL-3569: ------------------------------------------ Summary: Reduce the performance impact of the cache of the TemplateService in a cluster Key: GTNPORTAL-3569 URL: https://issues.jboss.org/browse/GTNPORTAL-3569 Project: GateIn Portal Issue Type: Enhancement Components: Performance Affects Versions: 3.8.8.Final Reporter: Nicolas Filotto While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the bug fix for https://issues.jboss.org/browse/GTNPORTAL-3410 is actually buggy and causes a significant performance regression. It is buggy because as the variable script of the class GroovyTemplate is transient, its value is not replicated over the cluster so far so good, the problem is that there is no synchronization mechanism to ensure that the value of this variable will be created only once even if we have several concurrent threads that try to access to its value, this is a real issue especially when we know that building the value of this particular variable has a significant cost. It causes a significant performance regression because it replaces an eXo Cache based on a ConcurrentHashMap with an eXo Cache based on ISPN in replicated mode, according to my micro benchmarks, the get method of a ConcurrentHashMap is 11 times faster than the get method of ISPN so when we know that the cache of the TemplateService is very frequently used we know that this configuration change will have a significant impact on performances -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 03:50:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 03:50:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3569) Reduce the performance impact of the cache of the TemplateService in a cluster In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Filotto updated GTNPORTAL-3569: --------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/gatein/gatein-portal/pull/922 > Reduce the performance impact of the cache of the TemplateService in a cluster > ------------------------------------------------------------------------------ > > Key: GTNPORTAL-3569 > URL: https://issues.jboss.org/browse/GTNPORTAL-3569 > Project: GateIn Portal > Issue Type: Enhancement > Components: Performance > Affects Versions: 3.8.8.Final > Reporter: Nicolas Filotto > > While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the bug fix for https://issues.jboss.org/browse/GTNPORTAL-3410 is actually buggy and causes a significant performance regression. > It is buggy because as the variable script of the class GroovyTemplate is transient, its value is not replicated over the cluster so far so good, the problem is that there is no synchronization mechanism to ensure that the value of this variable will be created only once even if we have several concurrent threads that try to access to its value, this is a real issue especially when we know that building the value of this particular variable has a significant cost. > It causes a significant performance regression because it replaces an eXo Cache based on a ConcurrentHashMap with an eXo Cache based on ISPN in replicated mode, according to my micro benchmarks, the get method of a ConcurrentHashMap is 11 times faster than the get method of ISPN so when we know that the cache of the TemplateService is very frequently used we know that this configuration change will have a significant impact on performances -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 03:59:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 03:59:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3570) Reduce the impact of the char and text encoders In-Reply-To: References: Message-ID: Nicolas Filotto created GTNPORTAL-3570: ------------------------------------------ Summary: Reduce the impact of the char and text encoders Key: GTNPORTAL-3570 URL: https://issues.jboss.org/browse/GTNPORTAL-3570 Project: GateIn Portal Issue Type: Enhancement Components: Performance Affects Versions: 3.8.8.Final Reporter: Nicolas Filotto While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the text and char encoders have a significant impact on performances. The goal of this improvement is to reduce the impact of the encoder. As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 04:11:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 04:11:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3570) Reduce the impact of the char and text encoders In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Filotto updated GTNPORTAL-3570: --------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/gatein/gatein-portal/pull/923 > Reduce the impact of the char and text encoders > ----------------------------------------------- > > Key: GTNPORTAL-3570 > URL: https://issues.jboss.org/browse/GTNPORTAL-3570 > Project: GateIn Portal > Issue Type: Enhancement > Components: Performance > Affects Versions: 3.8.8.Final > Reporter: Nicolas Filotto > > While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the text and char encoders have a significant impact on performances. > The goal of this improvement is to reduce the impact of the encoder. As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 04:12:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 04:12:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3570) Reduce the impact of the char and text encoders In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Filotto updated GTNPORTAL-3570: --------------------------------------- Attachment: Encoder.zip > Reduce the impact of the char and text encoders > ----------------------------------------------- > > Key: GTNPORTAL-3570 > URL: https://issues.jboss.org/browse/GTNPORTAL-3570 > Project: GateIn Portal > Issue Type: Enhancement > Components: Performance > Affects Versions: 3.8.8.Final > Reporter: Nicolas Filotto > Attachments: Encoder.zip > > > While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the text and char encoders have a significant impact on performances. > The goal of this improvement is to reduce the impact of the encoder. As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 04:20:40 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 04:20:40 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3571) Improve as much as possible the performance of the Router In-Reply-To: References: Message-ID: Nicolas Filotto created GTNPORTAL-3571: ------------------------------------------ Summary: Improve as much as possible the performance of the Router Key: GTNPORTAL-3571 URL: https://issues.jboss.org/browse/GTNPORTAL-3571 Project: GateIn Portal Issue Type: Enhancement Components: Performance Affects Versions: 3.8.8.Final Reporter: Nicolas Filotto While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the Router was very often used so any duplicate method calls or private variables accesses can have an impact especially when it is called millions of times. As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 04:24:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 04:24:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3571) Improve as much as possible the performance of the Router In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Filotto updated GTNPORTAL-3571: --------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/gatein/gatein-portal/pull/924 > Improve as much as possible the performance of the Router > --------------------------------------------------------- > > Key: GTNPORTAL-3571 > URL: https://issues.jboss.org/browse/GTNPORTAL-3571 > Project: GateIn Portal > Issue Type: Enhancement > Components: Performance > Affects Versions: 3.8.8.Final > Reporter: Nicolas Filotto > Attachments: Access.zip > > > While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the Router was very often used so any duplicate method calls or private variables accesses can have an impact especially when it is called millions of times. > As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 04:24:39 2014 From: issues at jboss.org (Nicolas Filotto (JIRA)) Date: Wed, 10 Dec 2014 04:24:39 -0500 (EST) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3571) Improve as much as possible the performance of the Router In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Filotto updated GTNPORTAL-3571: --------------------------------------- Attachment: Access.zip > Improve as much as possible the performance of the Router > --------------------------------------------------------- > > Key: GTNPORTAL-3571 > URL: https://issues.jboss.org/browse/GTNPORTAL-3571 > Project: GateIn Portal > Issue Type: Enhancement > Components: Performance > Affects Versions: 3.8.8.Final > Reporter: Nicolas Filotto > Attachments: Access.zip > > > While trying to identify the root cause of the performances regression between JPP 6.1.1 and JPP 6.2, I realized that the Router was very often used so any duplicate method calls or private variables accesses can have an impact especially when it is called millions of times. > As attached file you will find the hot spots before and after the fix proposed in the PR -- This message was sent by Atlassian JIRA (v6.3.8#6338)