[gatein-issues] [JBoss JIRA] (GTNPORTAL-3572) Missing exception handling in MembeshipDAOImpl

[Peter Palaga (JIRA)]

     [ https://issues.jboss.org/browse/GTNPORTAL-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Palaga updated GTNPORTAL-3572:
------------------------------------
           Status: Resolved  (was: Pull Request Sent)
    Fix Version/s: 3.8.14.Final
                   3.9.0.Final
       Resolution: Done


> Missing exception handling in MembeshipDAOImpl
> ----------------------------------------------
>
>                 Key: GTNPORTAL-3572
>                 URL: https://issues.jboss.org/browse/GTNPORTAL-3572
>             Project: GateIn Portal
>          Issue Type: Bug
>          Components: Identity integration
>    Affects Versions: 3.8.2.Final
>            Reporter: Martin Weiler
>            Assignee: Boleslaw Dawidowicz
>             Fix For: 3.8.14.Final, 3.9.0.Final
>
>
> MembershipDAOImpl.linkMembership(...) is missing exception handling around the following call:
> {code}
> getIdentitySession().getRoleManager().createRole(mt.getName(), user.getUserName(), groupId);
> {code}
> If this call fails, eg. for example due to an exception from the underlying database, this result in a corrupted transaction state. Subsequent requests using this thread fail with an error similar to the following:
> {noformat}
>  org.hibernate.AssertionFailure: null id in org.picketlink.idm.impl.model.hibernate.HibernateIdentityObjectRelationship entry (don't flush the Session after an exception occurs)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)