From issues at jboss.org Fri Apr 1 01:04:00 2016 From: issues at jboss.org (Hai Nguyen (JIRA)) Date: Fri, 1 Apr 2016 01:04:00 -0400 (EDT) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-2169) Header values case sensitive In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on GTNPORTAL-2169 started by Hai Nguyen. --------------------------------------------- > Header values case sensitive > ---------------------------- > > Key: GTNPORTAL-2169 > URL: https://issues.jboss.org/browse/GTNPORTAL-2169 > Project: GateIn Portal > Issue Type: Feature Request > Components: Common integration > Affects Versions: 3.1.0-GA, 3.2.0-M01 > Reporter: Ronny Pscheidl > Assignee: Hai Nguyen > Fix For: 3.x > > > case sensitiv problem with getHeaders in portal-container. > For example, if you call request.getHeader("Wicket-Ajax") without portal-container you get the value of this parameter. if you call this in portal-container you get null. in both cases the header value is set. the difference is, that without portal-container you get these parameters by javax.xml.soap.MimeHeaders. it implements getHeader like this with equalsIgnoreCase: > public String[] getHeader(String name) { > Vector values = new Vector(); > for(int i = 0; i < headers.size(); i++) { > MimeHeader hdr = (MimeHeader) headers.elementAt(i); > if (hdr.getName().equalsIgnoreCase(name) > && hdr.getValue() != null) > values.addElement(hdr.getValue()); > } > if (values.size() == 0) > return null; > String r[] = new String[values.size()]; > values.copyInto(r); > return r; > } > With portal-container you get the header parameter by SimpleMultiValuedProperty method getValue which doesn't ignore case sensetive. so we have to overwrite the method getHeader and getHeaders in our HttpServletRequestWrapper. is there a way to change this in gatein to use also MimeHeaders in PortletRequestImpl instead of SimpleMultiValuedProperty. -- This message was sent by Atlassian JIRA (v6.4.11#64026) From issues at jboss.org Mon Apr 4 06:35:00 2016 From: issues at jboss.org (Hai Nguyen (JIRA)) Date: Mon, 4 Apr 2016 06:35:00 -0400 (EDT) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3258) Allow classpath resolver to accept a leading slash In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185843#comment-13185843 ] Hai Nguyen commented on GTNPORTAL-3258: --------------------------------------- This issues has fixed > Allow classpath resolver to accept a leading slash > -------------------------------------------------- > > Key: GTNPORTAL-3258 > URL: https://issues.jboss.org/browse/GTNPORTAL-3258 > Project: GateIn Portal > Issue Type: Enhancement > Reporter: Hai Nguyen > Assignee: Hai Nguyen > Priority: Minor > Fix For: 3.7.0.Final > > > Classpath Resolver for resources does not currently support a leading slash. So for example in a webui component I can't put (or my template won't be found) : > {code} > @ComponentConfig ( > template = "classpath:/path/oto/my/template/MyTemplate.gtmpl", > events = { > } > ) > {code} > whereas this notation is allowed in kernel configuration. For example I can do : > {code} > classpath:/path/to/my/configuration/file/my-configuration.xml > {code} > and it is also allowed in the "app" resolver (I can do "app:/path/oto/my/template/MyTemplate.gtmpl"). > It would be more consistent and less error-prone for the developer to allow to add a leading slash for the classpath resolver. -- This message was sent by Atlassian JIRA (v6.4.11#64026) From issues at jboss.org Mon Apr 4 06:42:00 2016 From: issues at jboss.org (Hai Nguyen (JIRA)) Date: Mon, 4 Apr 2016 06:42:00 -0400 (EDT) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3258) Allow classpath resolver to accept a leading slash In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185848#comment-13185848 ] Hai Nguyen commented on GTNPORTAL-3258: --------------------------------------- This issues has fixed > Allow classpath resolver to accept a leading slash > -------------------------------------------------- > > Key: GTNPORTAL-3258 > URL: https://issues.jboss.org/browse/GTNPORTAL-3258 > Project: GateIn Portal > Issue Type: Enhancement > Reporter: Hai Nguyen > Assignee: Hai Nguyen > Priority: Minor > Fix For: 3.7.0.Final > > > Classpath Resolver for resources does not currently support a leading slash. So for example in a webui component I can't put (or my template won't be found) : > {code} > @ComponentConfig ( > template = "classpath:/path/oto/my/template/MyTemplate.gtmpl", > events = { > } > ) > {code} > whereas this notation is allowed in kernel configuration. For example I can do : > {code} > classpath:/path/to/my/configuration/file/my-configuration.xml > {code} > and it is also allowed in the "app" resolver (I can do "app:/path/oto/my/template/MyTemplate.gtmpl"). > It would be more consistent and less error-prone for the developer to allow to add a leading slash for the classpath resolver. -- This message was sent by Atlassian JIRA (v6.4.11#64026) From issues at jboss.org Mon Apr 18 04:07:00 2016 From: issues at jboss.org (Hai Nguyen (JIRA)) Date: Mon, 18 Apr 2016 04:07:00 -0400 (EDT) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3258) Allow classpath resolver to accept a leading slash In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192919#comment-13192919 ] Hai Nguyen commented on GTNPORTAL-3258: --------------------------------------- This issues has fixed > Allow classpath resolver to accept a leading slash > -------------------------------------------------- > > Key: GTNPORTAL-3258 > URL: https://issues.jboss.org/browse/GTNPORTAL-3258 > Project: GateIn Portal > Issue Type: Enhancement > Reporter: Hai Nguyen > Assignee: Hai Nguyen > Priority: Minor > Fix For: 3.7.0.Final > > > Classpath Resolver for resources does not currently support a leading slash. So for example in a webui component I can't put (or my template won't be found) : > {code} > @ComponentConfig ( > template = "classpath:/path/oto/my/template/MyTemplate.gtmpl", > events = { > } > ) > {code} > whereas this notation is allowed in kernel configuration. For example I can do : > {code} > classpath:/path/to/my/configuration/file/my-configuration.xml > {code} > and it is also allowed in the "app" resolver (I can do "app:/path/oto/my/template/MyTemplate.gtmpl"). > It would be more consistent and less error-prone for the developer to allow to add a leading slash for the classpath resolver. -- This message was sent by Atlassian JIRA (v6.4.11#64026) From issues at jboss.org Mon Apr 18 04:15:03 2016 From: issues at jboss.org (Hai Nguyen (JIRA)) Date: Mon, 18 Apr 2016 04:15:03 -0400 (EDT) Subject: [gatein-issues] [JBoss JIRA] (GTNPORTAL-3258) Allow classpath resolver to accept a leading slash In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/GTNPORTAL-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192932#comment-13192932 ] Hai Nguyen commented on GTNPORTAL-3258: --------------------------------------- This issues has fixed > Allow classpath resolver to accept a leading slash > -------------------------------------------------- > > Key: GTNPORTAL-3258 > URL: https://issues.jboss.org/browse/GTNPORTAL-3258 > Project: GateIn Portal > Issue Type: Enhancement > Reporter: Hai Nguyen > Assignee: Hai Nguyen > Priority: Minor > Fix For: 3.7.0.Final > > > Classpath Resolver for resources does not currently support a leading slash. So for example in a webui component I can't put (or my template won't be found) : > {code} > @ComponentConfig ( > template = "classpath:/path/oto/my/template/MyTemplate.gtmpl", > events = { > } > ) > {code} > whereas this notation is allowed in kernel configuration. For example I can do : > {code} > classpath:/path/to/my/configuration/file/my-configuration.xml > {code} > and it is also allowed in the "app" resolver (I can do "app:/path/oto/my/template/MyTemplate.gtmpl"). > It would be more consistent and less error-prone for the developer to allow to add a leading slash for the classpath resolver. -- This message was sent by Atlassian JIRA (v6.4.11#64026)