[Hawkular-commits] [hawkular/hawkular-build-tools] cc3e63: expanding the settings.jar into set of config file...

Peter Palaga ppalaga at redhat.com
Wed Aug 5 11:10:51 EDT 2015 

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-build-tools
  Commit: cc3e6339a5f6f75042b2043b9adbfae2bb946668
      https://github.com/hawkular/hawkular-build-tools/commit/cc3e6339a5f6f75042b2043b9adbfae2bb946668
  Author: Jirka Kremser <jkremser at redhat.com>
  Date:   2015-08-04 (Tue, 04 Aug 2015)

  Changed paths:
    A ide-configs/idea/assembly.xml
    A ide-configs/idea/config/IntelliJ IDEA Global Settings
    A ide-configs/idea/config/codestyles/Hawkular.xml
    A ide-configs/idea/config/fileTemplates/includes/File Header.java
    A ide-configs/idea/config/fileTemplates/includes/License.java
    A ide-configs/idea/config/fileTemplates/includes/LicenseJsp.jsp
    A ide-configs/idea/config/fileTemplates/includes/LicenseXml.xml
    A ide-configs/idea/config/fileTemplates/internal/AnnotationType.java
    A ide-configs/idea/config/fileTemplates/internal/Class.java
    A ide-configs/idea/config/fileTemplates/internal/Enum.java
    A ide-configs/idea/config/fileTemplates/internal/Interface.java
    A ide-configs/idea/config/fileTemplates/internal/package-info.java
    A ide-configs/idea/config/fileTemplates/j2ee/GroovyClass.groovy
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_2.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_3.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_4.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.5.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_2.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_3.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_4.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_5.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.3_0.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.3_1.xml
    A ide-configs/idea/config/installed.txt
    A ide-configs/idea/config/options/code.style.schemes.xml
    A ide-configs/idea/pom.xml
    R ide-configs/idea/settings.jar
    A ide-configs/pom.xml
    M pom.xml

  Log Message:
  -----------
  expanding the settings.jar into set of config files to better track the changes, mvn install will create the settings.jar that can be imported in idea


  Commit: 0a9e9d83f820a90768203f250878b08a7346e3b4
      https://github.com/hawkular/hawkular-build-tools/commit/0a9e9d83f820a90768203f250878b08a7346e3b4
  Author: Jirka Kremser <jkremser at redhat.com>
  Date:   2015-08-04 (Tue, 04 Aug 2015)

  Changed paths:
    M ide-configs/idea/config/codestyles/Hawkular.xml

  Log Message:
  -----------
  fixing the import order issue in idea


  Commit: 82cd5ccd2795477f5ea63cbfa55aba67656c6485
      https://github.com/hawkular/hawkular-build-tools/commit/82cd5ccd2795477f5ea63cbfa55aba67656c6485
  Author: Jirka Kremser <jkremser at redhat.com>
  Date:   2015-08-04 (Tue, 04 Aug 2015)

  Changed paths:
    A ide-configs/idea/README.adoc
    M ide-configs/idea/pom.xml
    M ide-configs/pom.xml

  Log Message:
  -----------
  minor: adding name element into pom.xml + README.adoc


  Commit: b061c0adfd3eeb41b7d9d99f631881dd16bf9245
      https://github.com/hawkular/hawkular-build-tools/commit/b061c0adfd3eeb41b7d9d99f631881dd16bf9245
  Author: Jirka Kremser <jkremser at redhat.com>
  Date:   2015-08-05 (Wed, 05 Aug 2015)

  Changed paths:
    M ide-configs/idea/config/codestyles/Hawkular.xml

  Log Message:
  -----------
  This commits forces each java construct to wrap if it is longer than 120
chars. Also it intends the same logical constructs on top of each other,
example:

myAwesomeBuilder.verrrryyyyLoooonnnnggggFoooooooooo1()
          .verrrryyyyLoooonnnnggggFoooooooooo2()
          .verrrryyyyLoooonnnnggggFoooooooooo3()

or during the method call:

myAwesomeMethod(verrrryyyyLoooonnnnggggFooooooooo1,
          verrrryyyyLoooonnnnggggFooooooooo2,
          verrrryyyyLoooonnnnggggFooooooooo3)

on the other hand, there are some corner cases where the combination of
the rules produces kind of strange looking lines like:

assertEquals("User should have no roles on resource", 0, personaService.getEffectiveRolesForResource(user,
                                                                                               resource)
                                                                 .size());

I.e. the method parameters are under each other and the chained method calls as
well. I found this more readable, even though strange looking at the
first sight.

All in all, it passes the checkstyle and we can improve on it.


  Commit: 6320205659a78d858041cd717110498789fa1cc0
      https://github.com/hawkular/hawkular-build-tools/commit/6320205659a78d858041cd717110498789fa1cc0
  Author: Jirka Kremser <jkremser at redhat.com>
  Date:   2015-08-05 (Wed, 05 Aug 2015)

  Changed paths:
    M ide-configs/idea/config/codestyles/Hawkular.xml

  Log Message:
  -----------
  commenting out the alligning of the same logical construct on top of each other


  Commit: f96ab1b755195f8b488ad18c60a964cac47e6066
      https://github.com/hawkular/hawkular-build-tools/commit/f96ab1b755195f8b488ad18c60a964cac47e6066
  Author: Peter Palaga <ppalaga at redhat.com>
  Date:   2015-08-05 (Wed, 05 Aug 2015)

  Changed paths:
    A ide-configs/idea/README.adoc
    A ide-configs/idea/assembly.xml
    A ide-configs/idea/config/IntelliJ IDEA Global Settings
    A ide-configs/idea/config/codestyles/Hawkular.xml
    A ide-configs/idea/config/fileTemplates/includes/File Header.java
    A ide-configs/idea/config/fileTemplates/includes/License.java
    A ide-configs/idea/config/fileTemplates/includes/LicenseJsp.jsp
    A ide-configs/idea/config/fileTemplates/includes/LicenseXml.xml
    A ide-configs/idea/config/fileTemplates/internal/AnnotationType.java
    A ide-configs/idea/config/fileTemplates/internal/Class.java
    A ide-configs/idea/config/fileTemplates/internal/Enum.java
    A ide-configs/idea/config/fileTemplates/internal/Interface.java
    A ide-configs/idea/config/fileTemplates/internal/package-info.java
    A ide-configs/idea/config/fileTemplates/j2ee/GroovyClass.groovy
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_2.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_3.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.1_4.xml
    A ide-configs/idea/config/fileTemplates/j2ee/application.5.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_2.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_3.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_4.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.2_5.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.3_0.xml
    A ide-configs/idea/config/fileTemplates/j2ee/web.3_1.xml
    A ide-configs/idea/config/installed.txt
    A ide-configs/idea/config/options/code.style.schemes.xml
    A ide-configs/idea/pom.xml
    R ide-configs/idea/settings.jar
    A ide-configs/pom.xml
    M pom.xml

  Log Message:
  -----------
  Merge pull request #22 from Jiri-Kremser/idea-import-order

Idea import order


Compare: https://github.com/hawkular/hawkular-build-tools/compare/24bd5e9e81b5...f96ab1b75519

More information about the hawkular-commits mailing list