[Hawkular-commits] [hawkular/hawkular] af809c: URL Availability Code Review Changes

Mike Thompson mtho11 at users.noreply.github.com
Tue Jul 21 15:58:13 EDT 2015


  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular
  Commit: af809c1ff6528571f138205b4ee521898a39a890
      https://github.com/hawkular/hawkular/commit/af809c1ff6528571f138205b4ee521898a39a890
  Author: Alexandre Mendonça <amendonca at redhat.com>
  Date:   2015-07-17 (Fri, 17 Jul 2015)

  Changed paths:
    M console/src/main/scripts/plugins/metrics/html/availability.html
    M console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts

  Log Message:
  -----------
  URL Availability Code Review Changes

- Replace template logic for downtime duration by controller function;
- Replace window usage by $window;
- Replace moment usage by $moment;
- Replace several ['parameter'] usage by dot notation, .parameter;
- Remove unused alertResolve function;


  Commit: 7ff9faa1943836826acc5180e989df3a2a38e8c9
      https://github.com/hawkular/hawkular/commit/7ff9faa1943836826acc5180e989df3a2a38e8c9
  Author: Alexandre Mendonça <amendonca at redhat.com>
  Date:   2015-07-20 (Mon, 20 Jul 2015)

  Changed paths:
    M console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts

  Log Message:
  -----------
  Small improvements to URL Availability code
- externalize duration limit values;
- comment unused variables;


  Commit: 9cb430e05feedd4244bcc630b7fa03087494614c
      https://github.com/hawkular/hawkular/commit/9cb430e05feedd4244bcc630b7fa03087494614c
  Author: Alexandre Mendonça <amendonca at redhat.com>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M console/src/main/scripts/plugins/metrics/html/availability.html
    M console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts

  Log Message:
  -----------
  Improve downtime duration retrieval in controller


  Commit: 73ee813b295e69b691df497e94bbb2728fe8d95d
      https://github.com/hawkular/hawkular/commit/73ee813b295e69b691df497e94bbb2728fe8d95d
  Author: Mike Thompson <mtho11 at users.noreply.github.com>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M console/src/main/scripts/plugins/metrics/html/availability.html
    M console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts

  Log Message:
  -----------
  Merge pull request #336 from ammendonca/HWK-CODE-REVIEW-URL-AVAILABILITY

URL Availability Code Review Changes


Compare: https://github.com/hawkular/hawkular/compare/476d9543e933...73ee813b295e


More information about the hawkular-commits mailing list