[Hawkular-commits] [hawkular/hawkular-alerts] 7bf29e: HWKALERTS-56 : Need a way to fetch Alerts without ...

[Jay Shaughnessy]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 7bf29eb2877890e117c0e67c556372d43e49eeb7
      https://github.com/hawkular/hawkular-alerts/commit/7bf29eb2877890e117c0e67c556372d43e49eeb7
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-04 (Thu, 04 Jun 2015)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Alert.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsCriteria.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
    M hawkular-alerts-rest/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java

  Log Message:
  -----------
  HWKALERTS-56 : Need a way to fetch Alerts without the evaluations
Add a "thin" query param to Alerts GET endpoint.  It currently will remove
the evalSets and resolvedEvalSets from the Alerts returned from the fetch.
This can be a good option for an initial list of alerts, where a more
robust pull of alert details can be deferred.


  Commit: 79b66bb7f81483411e571f324172736bf3bb3192
      https://github.com/hawkular/hawkular-alerts/commit/79b66bb7f81483411e571f324172736bf3bb3192
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-05 (Fri, 05 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy

  Log Message:
  -----------
  - Add a dedicated i-test for alert fetch. As is always the case, add more
  test code, find more bugs...
- Fix bug when using tags filter. When specifying a tags filter, if those
  tags result in no triggerIds, that is equivalent to searching for alerts
  on an empty trigger set, in other words - return no alerts. We were
  ignoring the tags filter and returning all alerts.
- Also refactor fetchAlerts to progressivly intersect the alertIds
  resulting from multiple filters.  This allows us to return an empty
  as soon as possible, potentially avoiding some unnecessary queries.


  Commit: 8dee6bcd31a5314022fb488c4aeb24c80b1cbd55
      https://github.com/hawkular/hawkular-alerts/commit/8dee6bcd31a5314022fb488c4aeb24c80b1cbd55
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-05 (Fri, 05 Jun 2015)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Alert.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsCriteria.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
    M hawkular-alerts-rest/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java

  Log Message:
  -----------
  Merge pull request #57 from jshaughn/hwkalerts-56

HWKALERTS-56 : Need a way to fetch Alerts without the evaluations

Lucas, I broke out the fetchAlerts testing into another test method, and added more tests.  Also, found a bug which I fixed.  As we discussed I'll now merge this PR. Thanks!


Compare: https://github.com/hawkular/hawkular-alerts/compare/d16d512ac189...8dee6bcd31a5