[Hawkular-commits] [hawkular/hawkular-metrics] d24abc: [HWKMETRICS-130] make time unit task interval and ...

John Sanda jsanda at redhat.com
Fri Jun 19 18:35:22 EDT 2015


  Branch: refs/heads/counter-rates
  Home:   https://github.com/hawkular/hawkular-metrics
  Commit: d24abcf44f3df8a33fe9617ca35ea7c1c4146e80
      https://github.com/hawkular/hawkular-metrics/commit/d24abcf44f3df8a33fe9617ca35ea7c1c4146e80
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M task-queue/src/main/java/org/hawkular/metrics/tasks/api/Task.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskContainer.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskImpl.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskServiceImpl.java
    M task-queue/src/test/java/org/hawkular/metrics/tasks/impl/TaskServiceTest.java

  Log Message:
  -----------
  [HWKMETRICS-130] make time unit task interval and window configurable

This is primarily to support testing. I do not think we are going to support
sub-minute intervals, but doing so makes tests easier/faster.


  Commit: 6ca87ab071971981880641bbc3caf81496fbe365
      https://github.com/hawkular/hawkular-metrics/commit/6ca87ab071971981880641bbc3caf81496fbe365
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M core/metrics-core-api/src/main/java/org/hawkular/metrics/core/api/MetricsService.java
    M core/metrics-core-impl/pom.xml
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/DataAccess.java
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/DataAccessImpl.java
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/MetricsServiceImpl.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/DataAccessITest.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/DelegatingDataAccess.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/MetricsITest.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-130] initial impl for generating/storing rate data


  Commit: df933ab035df5b3c39e17d5afde6725bd1ea63cf
      https://github.com/hawkular/hawkular-metrics/commit/df933ab035df5b3c39e17d5afde6725bd1ea63cf
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskImpl.java
    M task-queue/src/test/java/org/hawkular/metrics/tasks/impl/TaskServiceTest.java

  Log Message:
  -----------
  [HWKMETRICS-130] fix test


  Commit: 0ccfc50260e0895557c0a7cbd7da9fa1ac82fd0b
      https://github.com/hawkular/hawkular-metrics/commit/0ccfc50260e0895557c0a7cbd7da9fa1ac82fd0b
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    A core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/RatesITest.java

  Log Message:
  -----------
  [HWKMETRICS-130] adding test to verify rates are generated


  Commit: 2cbc856d55b49c8b1f7a3e91f8372eed7b531a8b
      https://github.com/hawkular/hawkular-metrics/commit/2cbc856d55b49c8b1f7a3e91f8372eed7b531a8b
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/DataAccessImpl.java
    A core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/FakeTaskService.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/MetricsServiceITest.java

  Log Message:
  -----------
  [HWKMETRICS] need to inject a TaskService into MetricsServiceImpl now


  Commit: d29aa5dec3f17027d31ec2f10ff528861118f53b
      https://github.com/hawkular/hawkular-metrics/commit/d29aa5dec3f17027d31ec2f10ff528861118f53b
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/MetricsServiceImpl.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/MetricsServiceITest.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/api/TaskType.java

  Log Message:
  -----------
  [HWKMETRICS-130] do not use hard coded values for task interval/window

Technically hard coded values are still being used, but it is possible to
change them by accessing and modifying MetricsServiceImpl.taskTypes. In the
future we ought to make them configurable vi tenant as well as per metric
configuration settings.


  Commit: 89bf6b3e00d2bc9ef933892eaf949805afc44b3b
      https://github.com/hawkular/hawkular-metrics/commit/89bf6b3e00d2bc9ef933892eaf949805afc44b3b
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/MetricsServiceImpl.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/FakeTaskService.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/RatesITest.java
    M schema-manager/src/main/resources/schema.cql
    M task-queue/src/main/java/org/hawkular/metrics/tasks/api/Task.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/api/TaskType.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/Queries.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskContainer.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskImpl.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskServiceImpl.java
    A task-queue/src/test/java/org/hawkular/metrics/tasks/impl/RxTest.java
    M task-queue/src/test/java/org/hawkular/metrics/tasks/impl/TaskServiceTest.java

  Log Message:
  -----------
  [HWKMETRICS-130] store tenant id with tasks in task queue


  Commit: 657cf139070833e1e9a4e76c9a9896164ee79749
      https://github.com/hawkular/hawkular-metrics/commit/657cf139070833e1e9a4e76c9a9896164ee79749
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    A core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/GenerateRate.java
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/MetricsServiceImpl.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/MetricsServiceITest.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/RatesITest.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/api/TaskType.java
    M task-queue/src/main/java/org/hawkular/metrics/tasks/impl/TaskServiceImpl.java
    R task-queue/src/test/java/org/hawkular/metrics/tasks/impl/RxTest.java
    M task-queue/src/test/java/org/hawkular/metrics/tasks/impl/TaskServiceTest.java

  Log Message:
  -----------
  [HWKMETRICS-130] refactor task execution

Prior to this commit the TaskType class provided a factory for producing an
object to exectue tasks. There are better ways to do this with RxJava. Now
clients register a subscriber with TaskService, and that subscriber is notified
of tasks to execute.

The code for computing rates has been pulled out of MetricsServiceImpl and put
into a new class, GenerateRate. This decouples MetricsServiceInmpl from the
computation of rates which will make it a lot easier to execute these various
components in isolation.


  Commit: 0a461d7aa325dc756450b6697924e32c414985a7
      https://github.com/hawkular/hawkular-metrics/commit/0a461d7aa325dc756450b6697924e32c414985a7
  Author: John Sanda <jsanda at redhat.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M core/metrics-core-api/src/main/java/org/hawkular/metrics/core/api/MetricsService.java
    M core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/MetricsServiceImpl.java
    A core/metrics-core-impl/src/main/java/org/hawkular/metrics/core/impl/TaskTypes.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/MetricsServiceITest.java
    M core/metrics-core-impl/src/test/java/org/hawkular/metrics/core/impl/RatesITest.java

  Log Message:
  -----------
  [HWKMETRICS-130] move task type configuration to its own class for now


Compare: https://github.com/hawkular/hawkular-metrics/compare/d5560253888b...0a461d7aa325


More information about the hawkular-commits mailing list