[Hawkular-commits] [hawkular/hawkular-alerts] 64cf80: Force English locale in mail decimal formatting

Lucas Ponce ponce.ballesteros at gmail.com
Wed Aug 17 04:13:23 EDT 2016


  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 64cf80e6a09803e60aebdf3e1684f5319c354a15
      https://github.com/hawkular/hawkular-alerts/commit/64cf80e6a09803e60aebdf3e1684f5319c354a15
  Author: Joel Takvorian <jtakvori at redhat.com>
  Date:   2016-08-16 (Tue, 16 Aug 2016)

  Changed paths:
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/EmailTemplate.java
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/PluginMessageDescription.java

  Log Message:
  -----------
  Force English locale in mail decimal formatting

Locale should be forced to English (rather that system default) since the whole mail is written in English.
Without it, we could end up with mixed languages/formatting such as "GC Duration greater than 1000,0 ms" with wrong decimal separator.

Note that the issue was seen from JUnit EmailTemplateTest:

Expected :Tiny template: Alert [open] message: GC Duration greater than 1000,0 ms for App Server thevault~Local
Actual   :Tiny template: Alert [open] message: GC Duration greater than 1000.0 ms for App Server thevault~Local


  Commit: 3b13f9b919a80e5d725299a91dc637633f49d145
      https://github.com/hawkular/hawkular-alerts/commit/3b13f9b919a80e5d725299a91dc637633f49d145
  Author: Joel Takvorian <jtakvori at redhat.com>
  Date:   2016-08-17 (Wed, 17 Aug 2016)

  Changed paths:
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/EmailTemplate.java
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/PluginMessageDescription.java

  Log Message:
  -----------
  Update licenses


  Commit: a7bf3c8600d7997032ad0e69ae81919b468ade9c
      https://github.com/hawkular/hawkular-alerts/commit/a7bf3c8600d7997032ad0e69ae81919b468ade9c
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2016-08-17 (Wed, 17 Aug 2016)

  Changed paths:
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/EmailTemplate.java
    M hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/src/main/java/org/hawkular/alerts/actions/email/PluginMessageDescription.java

  Log Message:
  -----------
  Merge pull request #198 from jotak/DecimalFormatInMails

Force English locale in mail decimal formatting


Compare: https://github.com/hawkular/hawkular-alerts/compare/fadea49fe8ec...a7bf3c8600d7


More information about the hawkular-commits mailing list