[Hawkular-commits] [hawkular/hawkular-metrics] 9be1f8: [HWKMETRICS-422] Avoid writing to the metrics inde...

[jsanda]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-metrics
  Commit: 9be1f83871c96a47fb7e6457de36a05c152ad9ac
      https://github.com/hawkular/hawkular-metrics/commit/9be1f83871c96a47fb7e6457de36a05c152ad9ac
  Author: Stefan Negrea <snegrea at redhat.com>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/DataAccess.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/DataAccessImpl.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java
    A core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/transformers/MetricFromDataRowTransformer.java
    A core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/transformers/MetricFromFullDataRowTransformer.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/DelegatingDataAccess.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/AvailabilityITest.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/BaseMetricsITest.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/GaugeITest.java

  Log Message:
  -----------
  [HWKMETRICS-422] Avoid writing to the metrics index on data point inserts. However, keep all the other writes to the metrics index in place.

Here are the changes to query metrics:
1) When requesting info about a single metric
  a) query the metrics index first, if found then return the info (just like before this change)
  b) if no result there, query the data table for a single data point, if found then the metric exists just not in the metrics index
  c) if no result in either metrics index or data table then there is no such metric

2) When requesting a list of all metrics for a tenant
  a) query the metrics index first
  b) query the data table for all metrics and filter by tenant and type if needed
  c) concat the two lists
  d) return only distinct values; note that the results from metrics index take precendence since they contain info about data retention and tags.

Note: After this change the metrics index will still contain metrics that have tags, non-default retention values, or have been explicitly created by the user. Metrics that just have data points will not have an entry in the metrics index table.


  Commit: b6bb3ec73ca809c73782568beffc3f9b9e23c209
      https://github.com/hawkular/hawkular-metrics/commit/b6bb3ec73ca809c73782568beffc3f9b9e23c209
  Author: Stefan Negrea <snegrea at redhat.com>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-422] Filter database rows first and compose metrics definitions later, this reduces the number of objects created.


  Commit: 3c72f4b42846ca95405c45358c09d17a0f931ac9
      https://github.com/hawkular/hawkular-metrics/commit/3c72f4b42846ca95405c45358c09d17a0f931ac9
  Author: Stefan Negrea <snegrea at redhat.com>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-422] Remove unneeded calls to findMetric. It is now almost equivalent to query for data of non-existing metric when compared to trying to find if a metric exists. Removing this call makes the stats method faster because it avoids a query to the metrics index.


  Commit: 7ba1dfe4f93654409a8a571baeff8dc32c43e537
      https://github.com/hawkular/hawkular-metrics/commit/7ba1dfe4f93654409a8a571baeff8dc32c43e537
  Author: Stefan Negrea <snegrea at redhat.com>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-422] Simplify idExists method by calling findMetric directly since the latter now authoritative in terms of the existance of a single metric.


  Commit: 9b7cdad1834d8bab178a498d6bbc501aa3142550
      https://github.com/hawkular/hawkular-metrics/commit/9b7cdad1834d8bab178a498d6bbc501aa3142550
  Author: Stefan Negrea <snegrea at redhat.com>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsService.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-422] Removing unneeded method discovered due to reviewing code that calls findMetric/findMetrics methods.


  Commit: fbf1ac67469e449378ccba84b2d9ce6ae43fbd93
      https://github.com/hawkular/hawkular-metrics/commit/fbf1ac67469e449378ccba84b2d9ce6ae43fbd93
  Author: jsanda <jsanda at redhat.com>
  Date:   2016-08-29 (Mon, 29 Aug 2016)

  Changed paths:
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/DataAccess.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/DataAccessImpl.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsService.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java
    A core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/transformers/MetricFromDataRowTransformer.java
    A core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/transformers/MetricFromFullDataRowTransformer.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/DelegatingDataAccess.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/AvailabilityITest.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/BaseMetricsITest.java
    M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/metrics/GaugeITest.java

  Log Message:
  -----------
  Merge pull request #575 from hawkular/no_midx

[HWKMETRICS-422] Avoid writing to the metrics index on data point inserts


Compare: https://github.com/hawkular/hawkular-metrics/compare/eb079b21d13f...fbf1ac67469e