[Hawkular-commits] [hawkular/hawkular-alerts] b05e33: HWKALERTS-209 NelsonRules

[Lucas Ponce]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: b05e33cf05f0a65dd4326ecfdaf14ecb1d530c5a
      https://github.com/hawkular/hawkular-alerts/commit/b05e33cf05f0a65dd4326ecfdaf14ecb1d530c5a
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2016-12-13 (Tue, 13 Dec 2016)

  Changed paths:
    M hawkular-alerts-actions/hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/hawkular-alerts-actions-email-plugin/src/main/java/org/hawkular/alerts/actions/email/PluginMessageDescription.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/json/JacksonDeserializer.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Condition.java
    A hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
    A hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/event/Alert.java
    M hawkular-alerts-api/src/test/java/org/hawkular/alerts/api/JsonTest.java
    M hawkular-alerts-engine/pom.xml
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/util/NelsonData.java
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/engine/rules/ConditionMatch.drl
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/schema/cassalog.groovy
    A hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/schema/updates/schema-1.5.0.groovy
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
    M hawkular-alerts-engine/src/test/resources/hawkular-alerts.properties
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ConditionsITest.groovy
    M pom.xml

  Log Message:
  -----------
  HWKALERTS-209 NelsonRules
- Introduce a new native condition type, NelsonCondition. This
condition uses "Nelson Rules" to detect "out-of-control" metric
behavior.  The condition establishes baseline metric behavior
based on a configurable metric sample (mean, stdDev) and uses the
baseline to perform analysis on the incoming measurements.
- Introduces apache math3 dep for engine
- Introduce new activeRules field in conditions table
- Fix bug with MISSING conditions in group trigger support

Also:
- fixes for HWKALERTS-208 because I was already adding some
  new condition support...
- improve the toString for Alert
- add some missing test support for a couple of condition types

PR Feedback
- make sample size configurable (and persisted) in NelsonCondition
  pros: - this makes it much easier to customize sampleSize based on the nature
    and collection rate of the relevant data.
  - this helps simplify NelsonData life-cycle (retraction)
  cons: - this duplicates work if the same dataId is used in multiple
    NelsonConditions (but we believe this to be a corner case)
- add rule to retract NelsonData when its owning NelsonCondition goes away
- fix  position mistake in NelsonConditionEval.violations
- add back lifecycle and resolvedEvalSets to Alert.toString(), by request
- use example to show default values in swagger
- make safe setters for activeRules and sampleSize


  Commit: 544024e6dadcb02a0b4c10b316bc11a645b1d44c
      https://github.com/hawkular/hawkular-alerts/commit/544024e6dadcb02a0b4c10b316bc11a645b1d44c
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M hawkular-alerts-actions/hawkular-alerts-actions-plugins/hawkular-alerts-actions-email/hawkular-alerts-actions-email-plugin/src/main/java/org/hawkular/alerts/actions/email/PluginMessageDescription.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/json/JacksonDeserializer.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Condition.java
    A hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
    A hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/event/Alert.java
    M hawkular-alerts-api/src/test/java/org/hawkular/alerts/api/JsonTest.java
    M hawkular-alerts-engine/pom.xml
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/util/NelsonData.java
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/engine/rules/ConditionMatch.drl
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/schema/cassalog.groovy
    A hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/schema/updates/schema-1.5.0.groovy
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
    M hawkular-alerts-engine/src/test/resources/hawkular-alerts.properties
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ConditionsITest.groovy
    M pom.xml

  Log Message:
  -----------
  Merge pull request #270 from jshaughn/nelson-rules

HWKALERTS-209 NelsonRules


Compare: https://github.com/hawkular/hawkular-alerts/compare/d8399d1d52f0...544024e6dadc