[Hawkular-commits] [hawkular/hawkular-metrics] b170f6: [HWKMETRICS-695] Fix NPE and several other issues

[Stefan Negrea]

  Branch: refs/heads/release/0.27.0
  Home:   https://github.com/hawkular/hawkular-metrics
  Commit: b170f65961a72f9c92041ef912a852f6c20311b6
      https://github.com/hawkular/hawkular-metrics/commit/b170f65961a72f9c92041ef912a852f6c20311b6
  Author: John Sanda <jsanda at redhat.com>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetaData.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java
    M api/metrics-api-util/src/main/java/org/hawkular/metrics/api/jaxrs/config/ConfigurationKey.java
    M containers/hawkular-openshift-security-filter/src/main/java/org/hawkular/openshift/auth/TokenAuthenticator.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/DropWizardReporter.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricRegistry.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricsRegistryListener.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularObjectNameFactory.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/MetaData.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  [HWKMETRICS-695] Fix NPE and several other issues

HawkularObjectNameFactory previously assumed every metric would have meta
data. TokenAuthenticator was registering metrics without meta data. I have
updated TokenAuthenticator so that it creates meta data. I have also
updated HawkularObjectNameFactory to handle the case where there is no
meta data.

There is another important change around the meta data. If a metric does
not have meta data, then its tags and data points will not get persisted.
A warning will get logged by HawkularMetricsRegistryListener about the
lack of meta data.

I have refactored the way in which internal metrics are registered.
Previously everything was done eagerly at start up. Now only meta data
is registered eagerly. Registering meta data will not cause anything to
be persisted in Cassandra. Metrics are registered lazily upon access.


  Commit: 7830ecf0a60be36f8ff95fe71ad9364d791c8b0a
      https://github.com/hawkular/hawkular-metrics/commit/7830ecf0a60be36f8ff95fe71ad9364d791c8b0a
  Author: John Sanda <jsanda at redhat.com>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java

  Log Message:
  -----------
  [HWKMETRICS-695] checkstyle


  Commit: f0bfcc6a0a9fd55ec8a8a3273de033cd028a3f5a
      https://github.com/hawkular/hawkular-metrics/commit/f0bfcc6a0a9fd55ec8a8a3273de033cd028a3f5a
  Author: John Sanda <jsanda at redhat.com>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AdminHandler.java

  Log Message:
  -----------
  [HWKMETRICS-695] register REST metrics dynamically


  Commit: ee38cecd4c59f8b2c808b4555d9a1cf010244d26
      https://github.com/hawkular/hawkular-metrics/commit/ee38cecd4c59f8b2c808b4555d9a1cf010244d26
  Author: John Sanda <jsanda at redhat.com>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java

  Log Message:
  -----------
  [HWKMETIRCS-695] checkstyle


  Commit: 59d504569f937fa2988d2946a256af0a78d6268c
      https://github.com/hawkular/hawkular-metrics/commit/59d504569f937fa2988d2946a256af0a78d6268c
  Author: Stefan Negrea <stefannegrea at users.noreply.github.com>
  Date:   2017-08-13 (Sun, 13 Aug 2017)

  Changed paths:
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetaData.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java
    M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AdminHandler.java
    M api/metrics-api-util/src/main/java/org/hawkular/metrics/api/jaxrs/config/ConfigurationKey.java
    M containers/hawkular-openshift-security-filter/src/main/java/org/hawkular/openshift/auth/TokenAuthenticator.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/DropWizardReporter.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricRegistry.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricsRegistryListener.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularObjectNameFactory.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/MetaData.java
    M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java

  Log Message:
  -----------
  Merge pull request #852 from jsanda/release/0.27.0-hwkmetrics-695

[HWKMETRICS-695] Fix NPE and several other issues


Compare: https://github.com/hawkular/hawkular-metrics/compare/e2aeba797064...59d504569f93