[Hawkular-commits] [hawkular/hawkular-alerts] ddc147: Prometheus external alerter (#354)

Jay Shaughnessy jshaughn at github.map.fastly.net
Tue Jun 27 16:05:27 EDT 2017


  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: ddc147297d21b4327a2e2179e8ef7c6984b62aa3
      https://github.com/hawkular/hawkular-alerts/commit/ddc147297d21b4327a2e2179e8ef7c6984b62aa3
  Author: Jay Shaughnessy <jshaughn at users.noreply.github.com>
  Date:   2017-06-27 (Tue, 27 Jun 2017)

  Changed paths:
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-metrics/pom.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-metrics/src/main/webapp/WEB-INF/beans.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-metrics/src/main/webapp/WEB-INF/jboss-web.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-metrics/src/main/webapp/WEB-INF/web.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/pom.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/src/main/webapp/WEB-INF/beans.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/src/main/webapp/WEB-INF/jboss-all.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/src/main/webapp/WEB-INF/jboss-deployment-structure.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/src/main/webapp/WEB-INF/jboss-web.xml
    A hawkular-alerters/hawkular-prometheus-alerter/deployments/hawkular-prometheus-alerter-standalone/src/main/webapp/WEB-INF/web.xml
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/pom.xml
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/java/org/hawkular/alerter/prometheus/BaseHttpClientGenerator.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/java/org/hawkular/alerter/prometheus/ConditionManager.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/java/org/hawkular/alerter/prometheus/HttpClientBuilder.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/java/org/hawkular/alerter/prometheus/QueryResponse.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/java/org/hawkular/alerter/prometheus/ServiceNames.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/main/resources/log4j2.xml
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/groovy/org/hawkular/alerter/prometheus/PrometheusITest.groovy
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/java/org/hawkular/alerter/prometheus/PrometheusQueryTest.java
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/resources/log4j2.xml
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/resources/prometheus-alert-trigger.json
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/resources/prometheus-alerts.rules
    A hawkular-alerters/hawkular-prometheus-alerter/hawkular-prometheus-alerter-lib/src/test/resources/prometheus-query-trigger.json
    A hawkular-alerters/hawkular-prometheus-alerter/pom.xml
    M hawkular-alerters/pom.xml
    M hawkular-alerts-rest-tests/pom.xml
    M pom.xml

  Log Message:
  -----------
  Prometheus external alerter (#354)

This is an initial alerter that can set up an ExternalCondition to execute
a Promql query and feed the results back as events for matching the
condition.
- There are two manual tests...
  - one tests a standard promql query
  - one tests a query against the special ALERTS timeseries when P8S is
    configured with alert rules.

Some things to think about given this POC:
- Should we use tags or context for the prometheus labels?
- How well will this really work given that prometheus could return
  many metrics for the single expression?
  - should we think about setting source? Data-driven groups here?




More information about the hawkular-commits mailing list